fix: can't properly drag and drop in empty record group #9039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented drag-and-drop functionality for empty record groups by introducing new components and modifying existing ones to properly handle draggable elements and ref management.
- Added new
packages/twenty-front/src/modules/object-record/record-table/record-table-row/components/RecordTableDraggableTr.tsxto encapsulate draggable table row logic - Modified
RecordTableRecordGroupSectionAddNew.tsxandRecordTableRecordGroupSectionLoadMore.tsxto support dragging with special index -1 for empty groups - Added
packages/twenty-front/src/utils/mergeRefs.tsutility to handle multiple React refs for drag-and-drop functionality - Updated
RecordTableActionRow.tsxto use RecordTableContext instead of Recoil for visible columns management - Refactored
RecordTableRowWrapper.tsxto delegate draggable functionality to the new RecordTableDraggableTr component
6 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
...rc/modules/object-record/record-table/record-table-row/components/RecordTableDraggableTr.tsx
Show resolved
Hide resolved
...rc/modules/object-record/record-table/record-table-row/components/RecordTableDraggableTr.tsx
Show resolved
Hide resolved
...-record/record-table/record-table-section/components/RecordTableRecordGroupSectionAddNew.tsx
Outdated
Show resolved
Hide resolved
...src/modules/object-record/record-table/record-table-row/components/RecordTableRowWrapper.tsx
Outdated
Show resolved
Hide resolved
.../src/modules/object-record/record-table/record-table-row/components/RecordTableActionRow.tsx
Show resolved
Hide resolved
...ecord/record-table/record-table-section/components/RecordTableRecordGroupSectionLoadMore.tsx
Outdated
Show resolved
Hide resolved
.../src/modules/object-record/record-table/record-table-row/components/RecordTableActionRow.tsx
Show resolved
Hide resolved
...rc/modules/object-record/record-table/record-table-row/components/RecordTableDraggableTr.tsx
Outdated
Show resolved
Hide resolved
...src/modules/object-record/record-table/record-table-row/components/RecordTableRowWrapper.tsx
Outdated
Show resolved
Hide resolved
magrinj
force-pushed
the
fix/drag-drop-record-group
branch
from
33b8b4b to
444e9e2
Compare
charlesBochet
approved these changes
Dec 12, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8968
Fix issue with drag and drop when record group are empty.
Happy to discuss the implementation, as it's limited to the
@hello-pangea/dndapi.