Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make DropdownMenuSeparator background transparent based on theme #9037

Merged
merged 8 commits into from
Dec 27, 2024
Merged

Fix: Make DropdownMenuSeparator background transparent based on theme #9037

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd4ed80
fix(chip): update padding for transparent variant
muraliSingh7 Nov 30, 2024
21b253f
Ensure consistent 8px padding-left across all table cells:
muraliSingh7 Dec 2, 2024
e53c70f
Refactored 0px to theme.spacing(0) for consistent spacing usage
muraliSingh7 Dec 3, 2024
5b24ca4
lint
guillim Dec 11, 2024
6d54f5b
Merge branch 'twentyhq:main' into main
muraliSingh7 Dec 12, 2024
157b54c
Fix: Make DropdownMenuSeparator background transparent based on theme
muraliSingh7 Dec 12, 2024
2dea8df
Fixed the indentation
muraliSingh7 Dec 12, 2024
9fb443f
Merge branch 'main' into main
lucasbordeau Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuSeparator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import styled from '@emotion/styled';

const StyledDropdownMenuSeparator = styled.div`
background-color: ${({ theme }) => theme.border.color.light};
background-color: ${({ theme }) =>
theme.name === 'dark'
? theme.background.transparent.light
: theme.border.color.light};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Inconsistent indentation in the template literal

min-height: 1px;

width: 100%;
`;

Expand Down
Loading