[Aggregate queries for table views - #2] Add aggregate queries footer for simple views #9025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces aggregate query functionality (sum, count, etc.) for table views, adding a new footer component that displays aggregate calculations for columns, with the feature protected behind a flag.
- Added new
RecordTableFootercomponent with sticky positioning and mobile responsiveness in/packages/twenty-front/src/modules/object-record/record-table/record-table-footer/components/RecordTableFooter.tsx - Added
useAggregateRecordsForRecordTableColumnFooterhook in/packages/twenty-front/src/modules/object-record/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter.tsxfor computing aggregate values - Extended
ColumnDefinitiontype with optionalaggregateOperationproperty in/packages/twenty-front/src/modules/object-record/record-table/types/ColumnDefinition.ts - Added
buildRecordGqlFieldsAggregateutility in/packages/twenty-front/src/modules/object-record/record-table/record-table-footer/utils/buildRecordGqlFieldsAggregate.tsfor constructing GraphQL aggregate queries - Added missing
aggregateOperationfield in view field update mutation in/packages/twenty-front/src/modules/views/hooks/internal/usePersistViewFieldRecords.ts
18 file(s) reviewed, 29 comment(s)
Edit PR Review Bot Settings | Greptile
...odules/object-record/record-board/record-board-column/utils/computeAggregateValueAndLabel.ts
Show resolved
Hide resolved
...odules/object-record/record-board/record-board-column/utils/computeAggregateValueAndLabel.ts
Show resolved
Hide resolved
...odules/object-record/record-board/record-board-column/utils/computeAggregateValueAndLabel.ts
Show resolved
Hide resolved
...record/record-table/record-table-footer/components/RecordTableColumnFooterAggregateValue.tsx
Outdated
Show resolved
Hide resolved
...bject-record/record-table/record-table-footer/components/RecordTableColumnFooterDropdown.tsx
Outdated
Show resolved
Hide resolved
| import { FieldMetadataType } from "~/generated/graphql"; | ||
| import { isDefined } from "~/utils/isDefined"; | ||
|
|
||
| export const getAvailableAggregateOperationsForFieldMetadataType = ({fieldMetadataType}: {fieldMetadataType?: FieldMetadataType}) => { |
There was a problem hiding this comment.
style: Inconsistent spacing in type definition - there should be a space after the colon
...cord-table/record-table-footer/utils/getAvailableAggregateOperationsForFieldMetadataType.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/utils/mapColumnDefinitionToViewField.ts
Show resolved
Hide resolved
Weiko
reviewed
Dec 11, 2024
...ord/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter.tsx
Outdated
Show resolved
Hide resolved
...odules/object-record/record-table/record-table-footer/utils/buildRecordGqlFieldsAggregate.ts
Outdated
Show resolved
Hide resolved
...cord-table/record-table-footer/utils/getAvailableAggregateOperationsForFieldMetadataType.tsx
Outdated
Show resolved
Hide resolved
...odules/object-record/record-board/record-board-column/utils/computeAggregateValueAndLabel.ts
Show resolved
Hide resolved
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are introducing aggregate queries on table views, behind a feature flag.
This does not work with view groups yet, nor with views that have records until the bottom. (both will be tackled next)