Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removeBillingFKWithCore migration location #9006

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Dec 10, 2024

removeBillingFKWithCore migration is in the wrong folder and is not executed as intended.
Moving to billing folder to fix that and to be only run in billing mode

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This change relocates a billing-related migration file to ensure it only executes when running in billing mode, affecting foreign key constraints between billing and workspace tables.

  • Migration file moved from /core/migrations/ to /core/migrations/billing/ directory to properly scope its execution
  • Removes three foreign key constraints in billingEntitlement, billingSubscription, and billingCustomer tables that reference workspace.id
  • Migration timestamp 1733753649142 indicates this should run after other billing table migrations

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weiko Weiko merged commit 96d56f8 into main Dec 10, 2024
19 checks passed
@Weiko Weiko deleted the c--fix-removeBillingFKWithCore-migration branch December 10, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants