Fixed dropdown bugs on 0.34 #9000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasbordeau
commented
Dec 10, 2024
•
lucasbordeau
commented
- New task dropdown wasn't using the proper dropdown id
- Action menu triggered by context menu (right click) on table cell was listening in edit mode.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses dropdown rendering and context menu issues across table cells and dropdown components, focusing on portal behavior, positioning, and focus management.
- Added context menu support in
RecordTableCellDisplayModeandRecordTableCellDisplayContainerto handle right-click actions - Introduced
avoidPortalprop inDropdownContentandDropdowncomponents to control portal rendering behavior - Implemented focus management in
useTriggerActionMenuDropdownusinguseSetActiveDropdownFocusIdAndMemorizePrevious - Removed styling from
RecordIndexActionMenuDropdowncontainer to fix z-index and positioning issues - Added
SHOW_PAGE_ADD_BUTTON_DROPDOWN_IDconstant for consistent dropdown identification
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+13
to
+15
| const handleActionMenuDropdown = (event: React.MouseEvent) => { | ||
| onActionMenuDropdownOpened(event, recordId); | ||
| }; |
There was a problem hiding this comment.
logic: event.preventDefault() should be called to prevent the default browser context menu from appearing
thomtrp
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.