Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings options #8996

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Settings options #8996

merged 4 commits into from
Dec 10, 2024

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Dec 10, 2024

  • text change
    image

  • CSS for settings cards
    Current :
    image
    Expected :
    image

@guillim guillim self-assigned this Dec 10, 2024
@guillim guillim marked this pull request as ready for review December 10, 2024 13:04
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the settings UI components with improved visual styling and organization.

  • Added new Separator component in settings/components/Separator.tsx for consistent visual separation between settings options
  • Modified settings cards to use rounded corners and proper background colors in SettingsOptionCardContentBase.tsx
  • Changed "Members" section title to "Manage Members" in workspace settings
  • Removed redundant divider prop in favor of explicit Separator component usage
  • Reorganized imports and styling in security options list for better maintainability

9 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@guillim guillim enabled auto-merge (squash) December 10, 2024 13:09
@guillim guillim merged commit afd3252 into main Dec 10, 2024
19 checks passed
@guillim guillim deleted the settings-options branch December 10, 2024 13:23
Copy link

Thanks @guillim for your contribution!
This marks your 22nd PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants