Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8964 add feature flag is page header v2 enabled #8995

Merged
merged 2 commits into from
Dec 10, 2024
Merged

8964 add feature flag is page header v2 enabled #8995

merged 2 commits into from
Dec 10, 2024

Conversation

bosiraphael
Copy link
Contributor

Closes #8964

@bosiraphael bosiraphael linked an issue Dec 10, 2024 that may be closed by this pull request
Add feature flag IS_PAGE_HEADER_V2_ENABLED #8964
Closed
greptile-apps[bot]
greptile-apps bot reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds a new feature flag 'IS_PAGE_HEADER_V2_ENABLED' to control UI updates across page headers and action menus, allowing for a coordinated release of multiple cosmetic changes.

  • Added feature flag to control button styles in multiple components (PageFavoriteButton, PageAddButton, ShowPageAddButton) switching from IconButton to Button with enhanced props
  • Modified pagination button placement in PageHeader.tsx - moves from left container to right action container when flag enabled
  • Added conditional rendering of command menu button in RecordIndexPageHeader with new styling
  • Set default value to true in feature flag seeds and added proper enum definitions in both front and backend

9 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

...wenty-front/src/modules/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/favorites/components/PageFavoriteButton.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/favorites/components/PageFavoriteButton.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/ui/layout/page/components/PageAddButton.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageAddButton.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/ui/layout/page/components/PageHeader.tsx Show resolved Hide resolved
packages/twenty-front/src/modules/ui/layout/page/components/PageHeader.tsx Show resolved Hide resolved
@Weiko Weiko merged commit d709876 into main Dec 10, 2024
19 checks passed
@Weiko Weiko deleted the 8964-add-feature-flag-is_page_header_v2_enabled branch December 10, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@thomtrp thomtrp thomtrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feature flag IS_PAGE_HEADER_V2_ENABLED
3 participants
@bosiraphael @thomtrp @Weiko