Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PG_DATABASE_URL to match Service name in k8s manifests #8989

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

azaurus1
Copy link
Contributor

@azaurus1 azaurus1 commented Dec 9, 2024

Issue Summary

The service name in the Kubernetes manifest for the PostgreSQL database is defined as twentycrm-db. However, the DSN configuration in the Server and Worker deployments incorrectly references twenty-db. This mismatch causes the pods to fail during initialization and crash on boot.

Fix Description

  • Updated the DSN values in both the Server and Worker deployments to correctly reference twentycrm-db, ensuring alignment with the database service name.
  • Verified the deployments to ensure the pods start without issues after the fix.

Testing

  • Deployed the updated manifests in a development environment.
  • Confirmed that both Server and Worker pods initialize correctly and connect to the database service as expected.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates PG_DATABASE_URL in Kubernetes manifests to correctly reference the database service name 'twentycrm-db' instead of 'twenty-db', fixing pod initialization failures.

  • Fixed database service reference in /packages/twenty-docker/k8s/manifests/deployment-worker.yaml and /packages/twenty-docker/k8s/manifests/deployment-server.yaml to match service name defined in service-db.yaml
  • Change ensures proper connectivity between server/worker pods and PostgreSQL database service
  • Aligns with Kubernetes service naming convention established in the twentycrm namespace

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FelixMalfait FelixMalfait merged commit bb5cc7e into twentyhq:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants