In navigation drawer, cursor should not be drag on hover and some enhancements #8975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the drag-and-drop user experience in the navigation drawer by hiding breadcrumbs during drag operations and improving cursor feedback.
- Added
isDraggingstate management inCurrentWorkspaceMemberFavoritesandCurrentWorkspaceMemberFavoritesFoldersto track active drag operations - Modified
NavigationDrawerItemBreadcrumbto hide breadcrumbs whenisDraggingis true via CSS visibility - Added
onDragStartprop toDraggableListcomponent to support drag state management - Simplified cursor behavior to show 'grabbing' only during active drag operations
- Renamed
isDraggableprop toisDraggingacross components for better semantic clarity
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsx
Show resolved
Hide resolved
...twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx
Outdated
Show resolved
Hide resolved
|
Thanks @ehconitin for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per the title- on hover, the draggable items had a grab cursor. Couldn't change it to a pointer, because then onClick would have a weird behavior of grab which causes lag onClick.