8928 refactor page header buttons #8952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Here's my summary of the key changes in this pull request:
Refactored page header buttons across the application to improve consistency and accessibility.
- Replaced IconButton with standardized Button component in multiple components, adding proper aria labels and titles
- Added command menu button (⌘K shortcut) to RecordIndexPageHeader and RecordShowPageBaseHeader
- Moved pagination buttons to right side of PageHeader alongside other action buttons for better layout consistency
- Changed button sizes from 'medium' to 'small' across page headers for visual consistency
- Added ariaLabel prop to base Button component in twenty-ui package to support accessibility improvements
9 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/favorites/components/PageFavoriteButton.tsx
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton.tsx
Show resolved
Hide resolved
...wenty-front/src/modules/ui/layout/page-header/components/PageHeaderOpenCommandMenuButton.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/page/components/PageHeader.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/page/components/PageHeader.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/page/components/PageAddButton.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/page/components/PageAddButton.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8928