Add current workspace member option to workspaceMember relation field filter (#8016)

[eliasylonen]

Issue: #8016

Almost ready to be merged.

This touches so many files that it could be good to:

• merge quickly after I fix the tests
• Add the "No Owner" / "No Assignee" button mentioned in I should be able to filter on workspaceMember = me #8016 separately
• Fix unselecting values not working (also broken in main) right after merging

[greptile-apps]

PR Summary

This PR adds a "current user" filter option for workspace member relations, similar to Linear's implementation, by refactoring filter-related functionality into hooks and adding special ID handling.

Key changes:

• Moves filter computation from utility functions to hooks (useComputeContextStoreFilters, useResolveFilterValue) for better state management
• Adds special CURRENT_WORKSPACE_MEMBER ID handling in useResolveRelationViewFilterValue to support "me" filter option
• Introduces safeStringArrayJSONSchema for consistent JSON string array validation
• Refactors filter value resolution to use simpler function signatures and improved type safety
• Consolidates query variable generation in new useGetQueryVariablesFromView hook

_{💡 (4/5) You can add custom instructions or style guidelines for the bot here!}

_{27 file(s) reviewed, 17 comment(s)
Edit PR Review Bot Settings | Greptile}

[FelixMalfait]

Great work as always! Starting to play around with it, noticed a first bug:

Screen.Recording.2024-12-09.at.09.02.50.mov

Edit: maybe that's what you meant by 'fix unselected values - broken on main'?

[FelixMalfait]

In a followup PR / issue, could you maybe add an "assigned to me" view in "tasks-all.view.ts" file (this will only apply to new workspaces). This will make your feature more discoverable

[FelixMalfait]

I think we can forget the "No assignee" from the initial issue as there is already "is empty" which is good enough

[lucasbordeau]

Please fix the tests

[lucasbordeau]

Could you also verify that your IDE is correctly configured ? The lint problem on the tests and the prettier/eslint problems should not be part of your commit since it should be auto-fixed at save or outputing red squiggles in your console.

[lucasbordeau]

With selectedRecordIdsAndSpecialIds, the naming tells us that there's a code smell, "DoingThisAndThat" indicates that we should split this into two distinc flows that join at the right abstraction level.

Here we should keep the previous flow as it is, with utils instead of hooks.

The changes seem to be only for relations and selection. You should explore a solution where you create recoil atoms for storing the state of what your new UI components are doing, then using those atoms where it's really needed, and copy/paste at multiple place if that's the things to do.

For example here contextStoreFilters seems to be more appropriate to store your additional current workspace member filter, and maybe a specific parallel hook/util could handle turning the click into a record filter and modify this state ?

[lucasbordeau]

That doesn't seem like the right way to go, storing magic ids to bypass the normal flow is always an anti-pattern for lack of a better solution.

Also special id is too vague as a naming and feels too "magic" which is something we really want to avoid

The fact that a lot of utils has been turned to hooks to accomodate a edge case for relation type is a code smell.

We can definitely find a solution that leaves those utils as is. I feel like we're not implemeting this on the right abstraction level.

[eliasylonen]

Continuing in PR #9182