-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Button Shortcut Style Enhancements + Additional Storybook Tests #8947
Conversation
…ted out style enhancements for shortcuts)
Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Enhanced button shortcuts with customized styling based on variants and accents, while updating Yarn version and improving Storybook documentation.
- Added variant-specific styling for shortcut separators and labels in
packages/twenty-ui/src/input/button/components/Button.tsx
with conditional colors based on button type - Enhanced
ShortcutCatalog
in Button stories to showcase shortcut styling across different button variants and accents - Upgraded Yarn package manager from 4.4.0 to 4.5.2 across configuration files
- Removed commented code blocks in Button component implementation
- Added proper color variations for shortcut text and vertical separators matching Figma design specs
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-ui/src/input/button/components/__stories__/Button.stories.tsx
Outdated
Show resolved
Hide resolved
Thanks @emshyu! I think the colors are different on Figma, also made a minor comment https://twenty.com/developers/section/frontend-development/work-with-figma |
@@ -416,8 +438,12 @@ export const Button = ({ | |||
{title} | |||
{shortcut && ( | |||
<> | |||
<StyledSeparator buttonSize={size} /> | |||
<StyledShortcutLabel>{shortcut}</StyledShortcutLabel> | |||
{/* <StyledSeparator buttonSize={size} />*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't leave old code as comments, that's what we use git for, we can always find it later if we need to :)
package.json
Outdated
@@ -343,7 +343,7 @@ | |||
}, | |||
"license": "AGPL-3.0", | |||
"name": "twenty", | |||
"packageManager": "yarn@4.4.0", | |||
"packageManager": "yarn@4.5.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a bit risky to change this as part of this unrelated PR but why not :) - anything in particular. that led you to change it? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think it may have changed accidentally when I ran something with Yarn. This shouldn't be necessary.
I just added in the admin token |
Thanks @emshyu! I think the colors are different on Figma, also made a minor comment Hi! I just updated the colors to match, should I make a new PR? |
Thanks @emshyu! I think the colors are different on Figma, also made a minor comment https://twenty.com/developers/section/frontend-development/work-with-figma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Resolves Issue #4871 (or enhances)
Additions