Fix infinite loading on field settings #8938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes infinite loading issues in field settings pages by optimizing GraphQL queries and state management, particularly around user data fetching and component rendering.
- Replaced
useGetCurrentUserQuerywith direct Apollo query inuseUpdateOneFieldMetadataItem.tsto prevent cascading rerenders - Added loading state check in
ObjectMetadataItemsLoadEffect.tsxto prevent premature state updates - Simplified field settings save flow in
SettingsObjectFieldEdit.tsxby moving navigation before updates - Reorganized user query fragments to ensure complete data fetching in a single query
- Added
network-onlyfetch policy for views query to ensure fresh data
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+74
to
+75
| const { data } = await apolloClient.query({ query: GET_CURRENT_USER }); | ||
| setCurrentWorkspace(data?.currentUser?.defaultWorkspace); |
There was a problem hiding this comment.
logic: No error handling for failed user query or missing defaultWorkspace. Could cause runtime errors if query fails.
Comment on lines
+129
to
136
| navigate(`/settings/objects/${objectSlug}`); | ||
|
|
||
| await updateOneFieldMetadataItem({ | ||
| objectMetadataId: objectMetadataItem.id, | ||
| fieldMetadataIdToUpdate: fieldMetadataItem.id, | ||
| updatePayload: formattedInput, | ||
| }); | ||
| } |
There was a problem hiding this comment.
logic: Navigation happens before the async update operation completes. This could lead to race conditions where the user sees stale data if they quickly navigate back.
charlesBochet
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were experiencing infinite loading on field settings pages (creation of new field), due to the fact that the component was being rendered on and on and on.
This was due to useGetCurrentUserQuery calls outside of the update function, causing renders in cascade. We also had an issue with the component being unmounted too often.