Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Icon CSS update #8934

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Settings Icon CSS update #8934

merged 1 commit into from
Dec 6, 2024

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Dec 6, 2024

Current :
image

Expected :
Screenshot 2024-12-06 at 17 01 45

Design Request from @Bonapara 😸

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates styling of settings icons and toggles to match new design requirements, focusing on size adjustments and spacing modifications.

  • Reduced icon container size from spacing(8) to spacing(7) in SettingsOptionCardContentBase.tsx
  • Changed icon size from xl to lg in SettingsOptionIconCustomizer.tsx
  • Decreased gap between elements from spacing(4) to spacing(3) in SettingsOptionCardContentBase.tsx
  • Added toggleSize="small" prop to Toggle component in SettingsOptionCardContentToggle.tsx

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@twentyhq twentyhq deleted a comment from greptile-apps bot Dec 6, 2024
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Weiko Weiko merged commit 4208bd2 into main Dec 6, 2024
19 checks passed
@Weiko Weiko deleted the css-icon-settings branch December 6, 2024 16:47
Copy link

github-actions bot commented Dec 6, 2024

Thanks @guillim for your contribution!
This marks your 19th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants