Split record crud actions #8930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR splits the previously unified record CRUD actions into separate specialized actions for better code organization and reduced complexity.
- Splits
RECORD_CRUDinto distinctCREATE_RECORD,UPDATE_RECORD,DELETE_RECORD, andFIND_RECORDaction types in/packages/twenty-front/src/modules/workflow/types/Workflow.ts - Removes utility functions like
isWorkflowRecordCreateActionin favor of direct action type checks - Adds dedicated workflow action classes like
CreateRecordWorkflowActionandUpdateRecordWorkflowActionin/packages/twenty-server/src/modules/workflow/workflow-executor/workflow-actions/record-crud/ - Updates
WorkflowActionFactoryandWorkflowBuilderWorkspaceServiceto handle the new separate action types ⚠️ Breaking change that requires migration of existing workflows using the previous combinedRECORD_CRUDaction type
25 file(s) reviewed, 18 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/workflow/components/WorkflowStepDetail.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/components/WorkflowDiagramStepNodeBase.tsx
Show resolved
Hide resolved
...les/workflow/workflow-executor/workflow-actions/record-crud/delete-record.workflow-action.ts
Show resolved
Hide resolved
...server/src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+37
to
+39
| await repository.update(workflowActionInput.objectRecordId, { | ||
| ...workflowActionInput.objectRecord, | ||
| }); |
There was a problem hiding this comment.
logic: potential race condition between findOne and update - record could be deleted between these operations
...les/workflow/workflow-executor/workflow-actions/record-crud/update-record.workflow-action.ts
Show resolved
Hide resolved
...les/workflow/workflow-executor/workflow-actions/record-crud/update-record.workflow-action.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a global record crud action adds complex logic.
We decided to split those actions. I only kept a common folder / module in backend.