feat: record group add new

[magrinj]

Fix #8757

This PR is adding the Add new button on view groups.
Also this PR fix an issue where the pending record can be draggable, and is causing error.

It also start to issues with the way we're using Context.
We're initializing pretty much all Context like this:

export const RecordTableContext = createContext<RecordTableContextProps>(
   {} as RecordTableContextProps,
 );

This is causing issues when by mistake we use the context like this outside the Provider hierarchy:

const context = useContext(RecordTableContext);

This is going to fail silently, and all the context variables become undefined...

To fix this I've introduced an util called createRequiredContext, this one is returning an array containing the provider and the hook to retrieve the context.
The context is initialized to undefined inside this utility, this way we can check if the value has been initialized with the provider to check if we're inside it. It'll throw an error if this one is used outside the provider.
The return values are properly typed, so undefined is not added to the value of the Context.

I'll create a followup ticket to use this new utility function, if that's ok and replace it everywhere in the codebase.
We can also consider adding a eslint rule to warn about the use of createContext directly.

[charlesBochet]

Closing for now, let's re-open once ready to keep the history clean

[greptile-apps]

PR Summary

This PR adds an "Add new" button feature for record groups and significantly improves context management across the codebase. Here's a concise summary of the key changes:

• Introduced /utils/create-required-context.ts utility to prevent silent failures when contexts are used outside providers, replacing unsafe empty object context initialization pattern
• Added RecordTableRecordGroupSectionAddNew component with "Add new" button functionality for record groups
• Added recordTablePendingRecordIdByGroupComponentFamilyState to track pending records per group
• Added RecordTablePendingRecordGroupRow to handle pending record UI within groups
• Refactored record creation logic from RecordIndexPage to be closer to where it's used, with proper group-specific handling

_{63 file(s) reviewed, 22 comment(s)
Edit PR Review Bot Settings | Greptile}

[charlesBochet]

Overall the approach seems fine to me, I have doubt on:

• wether we should try to make the new record logic work with both no record group and record groups or if we should duplicate it so simplify a bit the logic. even, If we choose to handle both in the same place, I think we should split very early in the logic to choose if we are in RecordGroup case and not call any recordGroup logic if we know we are not in a recordGroup case (not a fan of the overload with allow undefined)
• I don't fully understand the need for "create-required-context". I think the devXP was confusing and you want to throw a clear error which is a good idea but wouldn't a useContextOrThrow work with less complexity? we create a regular context and when we read it only we throw?

[charlesBochet]

should this be in record table or record index ? does it work for Board too?

[magrinj]

Actually it doesn't work for RecordBoard for now, I put a TODO because to make it work we need to merge some states.
I put the file in this directory because the Kanban one is already there, I think we should move them during the refactor.

[charlesBochet]

love it, much clearer to me

[charlesBochet]

nice!

[charlesBochet]

Bravo @magrinj, very clear and easy to read and understand
Thanks for all the side improvements too (removed unused props, useless wrapping)

nice we have new context api too

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ Error: RecordIndexContext Context not found. Please wrap your component tree with <RecordIndexContextPro... /object/person/0db58898-3466-4a16-944e-d0a4e387... View Issue
• ‼️ Error: Record field type not supported : SELECT} /settings/objects/people View Issue
• ‼️ Error: Record field type not supported : DATE} /objects/programs View Issue

_{Did you find this useful? React with a 👍 or 👎}