Favorites Folders Fast Followups #8920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refines the favorites folder functionality with UI and interaction improvements across navigation drawer and dropdown components.
- Changed
FavoriteFolderNavigationDrawerItemDropdowndropdown placement to 'bottom-start' with fixed 160px width for better positioning - Added
StyledOrphanFavoritesContainerinCurrentWorkspaceMemberFavoritesFoldersfor consistent spacing between favorite items - Implemented
handleAddToFavoritesinPageFavoriteFolderDropdownto prevent duplicate favorites - Reduced right padding from 1 to 0.5 spacing units in
NavigationDrawerItemfor better layout with folder options - Simplified
NavigationDrawerSectionTitleby moving click handler toStyledLabeland removing redundant right icon interactions
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
...ges/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavoritesFolders.tsx
Show resolved
Hide resolved
...ges/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavoritesFolders.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/favorites/components/PageFavoriteFolderDropdown.tsx
Outdated
Show resolved
Hide resolved
...ront/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerSectionTitle.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR updates the favorites folder UI behavior to ensure the dropdown only appears after an item is favorited, along with several UI refinements.
- Modified
RecordShowPageBaseHeaderto conditionally renderPageFavoriteFoldersDropdownonly when item is favorited - Removed duplicate click handlers in
NavigationDrawerSectionTitleto prevent double-firing - Simplified
PageFavoriteFolderDropdownby removinguseCreateFavoritehook and unused imports - Added margin fixes and menu width constraints for better dropdown positioning
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -77,7 +77,7 @@ const StyledItem = styled('button', { | |||
|
|
|||
| padding-bottom: ${({ theme }) => theme.spacing(1)}; | |||
| padding-left: ${({ theme }) => theme.spacing(1)}; | |||
| padding-right: ${({ theme }) => theme.spacing(1)}; | |||
| padding-right: ${({ theme }) => theme.spacing(0.5)}; | |||
There was a problem hiding this comment.
@ehconitin this will impact all navigation drawer items, is this expected? (not only the workspace favorites). This seems suspicious!
There was a problem hiding this comment.
Ok but how is it now broken on main branch ? it seems fine to me at least on production?
There was a problem hiding this comment.
I am not sure! I went through history of NavigationDrawerItem and it was always like this i.e, 4px padding all around
There was a problem hiding this comment.
@charlesBochet should we close this? or do you need me to dig deeper into it?
There was a problem hiding this comment.
Thanks @ehconitin, left comments!
I have tested if functionnally and it feels nicer indeed
| @@ -17,7 +17,10 @@ const StyledTitle = styled.div` | |||
| font-size: ${({ theme }) => theme.font.size.xs}; | |||
| font-weight: ${({ theme }) => theme.font.weight.semiBold}; | |||
| height: ${({ theme }) => theme.spacing(5)}; | |||
| padding: ${({ theme }) => theme.spacing(1)}; | |||
| padding-left: ${({ theme }) => theme.spacing(1)}; | |||
| padding-right: ${({ theme }) => theme.spacing(0.5)}; | |||
There was a problem hiding this comment.
this padding right 0.5 is suspicious!
Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes :
Fixes: Reduce menu width to 160px and it should appear below three dots
Fixes: The right margin should be 2px
Fixes:
Requirement: Clicking the heart Icon should put the record as favorite. It shouldn't open the menu on first click. It should only on second click, when the record is already a favorite.