Dropdown in dropdown #8911
Merged
Dropdown in dropdown #8911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds scrolling functionality to dropdowns with many items by implementing a ScrollWrapper component, ensuring all items remain accessible when the dropdown content exceeds the maximum height.
- Added
ScrollWrapperimport in/packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuItemsContainer.tsxfor scroll management - Set fixed maximum height of 188px in
StyledDropdownMenuItemsExternalContainerwhenhasMaxHeightprop is true - Implemented overflow scrolling behavior to prevent dropdowns from extending beyond screen boundaries
- Added conditional rendering logic to handle nested dropdown scenarios
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuItemsContainer.tsx
Show resolved
Hide resolved
|
Thanks @guillim for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropdown in dropdown bug
while still fixing scroll issue
fix #8716