Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration folder #8909

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix migration folder #8909

merged 1 commit into from
Dec 5, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Dec 5, 2024

Context

Common migrations now live in a different directory however the PR that added that behavior was not up to date with the few migrations that were merged recently.

This PR moves the migrations to the correct folder so they can be executed properly.

Test

reset-db

Before
Screenshot 2024-12-05 at 18 14 13
After
Screenshot 2024-12-05 at 18 15 40

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR reorganizes migration files by moving them to a common directory for better organization and proper execution of database changes.

  • Moved fixUserEmailUniqueConstraint migration to modify email uniqueness constraints, allowing duplicate emails for soft-deleted users
  • Relocated addAuthProvidersColumnsToWorkspace migration that adds Microsoft, Google, and password authentication toggles to workspaces
  • Transferred addSubdomainToWorkspace migration that adds and initializes unique workspace subdomains
  • All migrations maintain their original functionality while being properly organized in /packages/twenty-server/src/database/typeorm/core/migrations/common/

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weiko Weiko requested a review from FelixMalfait December 5, 2024 17:15
@FelixMalfait FelixMalfait merged commit 815e5df into main Dec 5, 2024
17 checks passed
@FelixMalfait FelixMalfait deleted the c--fix-migration-folder branch December 5, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants