Add delete record action #8908
Merged
Add delete record action #8908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomtrp
commented
Dec 5, 2024
thomtrp
commented
- Adding new action
- Adding tests
- Moving into action folder
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a new Delete Record action to the workflow system, enabling users to delete records through workflow automation.
- Added new
RECORD_CRUD.DELETEaction type in/packages/twenty-front/src/modules/workflow/constants/Actions.tswith corresponding UI components - Implemented
WorkflowEditActionFormRecordDeletecomponent in/workflow-actions/components/for selecting objects and records to delete - Added type guard
isWorkflowRecordDeleteActionwith comprehensive test coverage in/workflow-actions/utils/ - Added server-side support in
workflow-version-step.workspace-service.tsfor handling delete record actions - Critical bug found in
isWorkflowRecordUpdateAction.test.tswhere test expectations are reversed for CREATE/UPDATE actions
13 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/workflow/components/WorkflowStepDetail.tsx
Show resolved
Hide resolved
...ront/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormRecordDelete.tsx
Show resolved
Hide resolved
...ront/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormRecordDelete.tsx
Show resolved
Hide resolved
...t/src/modules/workflow/workflow-actions/utils/__tests__/isWorkflowRecordDeleteAction.test.ts
Outdated
Show resolved
Hide resolved
...t/src/modules/workflow/workflow-actions/utils/__tests__/isWorkflowRecordDeleteAction.test.ts
Outdated
Show resolved
Hide resolved
...t/src/modules/workflow/workflow-actions/utils/__tests__/isWorkflowRecordUpdateAction.test.ts
Outdated
Show resolved
Hide resolved
...t/src/modules/workflow/workflow-actions/utils/__tests__/isWorkflowRecordUpdateAction.test.ts
Outdated
Show resolved
Hide resolved
...t/src/modules/workflow/workflow-actions/utils/__tests__/isWorkflowRecordUpdateAction.test.ts
Outdated
Show resolved
Hide resolved
...ges/twenty-front/src/modules/workflow/workflow-actions/utils/isWorkflowRecordDeleteAction.ts
Show resolved
Hide resolved
...er/src/modules/workflow/common/workspace-services/workflow-version-step.workspace-service.ts
Show resolved
Hide resolved
martmull
approved these changes
Dec 5, 2024
| @@ -169,6 +169,27 @@ export class WorkflowVersionStepWorkspaceService { | |||
| }, | |||
| }; | |||
| } | |||
| case `${WorkflowActionType.RECORD_CRUD}.${WorkflowRecordCRUDType.DELETE}`: { | |||
There was a problem hiding this comment.
Indeed, we need to fix that, in a dedicated PR probably
Comment on lines
+124
to
+131
| if (actionOptions.readonly === true) { | ||
| return; | ||
| } | ||
|
|
||
| actionOptions.onActionUpdate({ | ||
| ...action, | ||
| name: newName, | ||
| }); |
There was a problem hiding this comment.
I wonder why we don't just add this readonly check directly in the onActionUpdate
There was a problem hiding this comment.
Actually when readonly is set, onActionUpdate has to be undefined (see props definition above).
We need the readonly props to disable buttons and fields in some actions. So we still need to pass the props. Adding the readonly in onActionUpdate would simply remove the check above.
But I actually like the component to have its logic and not trust blindly the parent so I am not sure I would even remove that check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.