8733 refactor gmailhandleerrorservice #8901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors Gmail error handling by splitting generic error handling into specific, well-tested utilities for different error types in the messaging import system.
- Added specialized error handlers in
gmail-handle-error.service.tsfor Gaxios, message list fetch, and message import errors - Created comprehensive mocks in
/mocks/gaxios-error-mocks.tsand/mocks/gmail-api-error-mocks.tsfor testing error scenarios - Added thorough test coverage in
/__tests__/directory for each error parsing utility - Modified error handling in Gmail services to use new specialized handlers instead of generic error handling
- Added new error parsing utilities in
/utils/for different error types with specific exception mapping
14 file(s) reviewed, 26 comment(s)
Edit PR Review Bot Settings | Greptile
...es/messaging/message-import-manager/drivers/gmail/services/gmail-get-message-list.service.ts
Show resolved
Hide resolved
...es/messaging/message-import-manager/drivers/gmail/services/gmail-get-message-list.service.ts
Show resolved
Hide resolved
...erver/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
Outdated
Show resolved
Hide resolved
...erver/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
Show resolved
Hide resolved
...er/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gmail-api-error-mocks.ts
Show resolved
Hide resolved
...ssaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts
Show resolved
Hide resolved
...messaging/message-import-manager/drivers/gmail/utils/parse-gmail-refresh-token-error.util.ts
Outdated
Show resolved
Hide resolved
...ssaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts
Show resolved
Hide resolved
...messaging/message-import-manager/drivers/gmail/utils/parse-gmail-refresh-token-error.util.ts
Outdated
Show resolved
Hide resolved
...messaging/message-import-manager/drivers/gmail/utils/parse-gmail-refresh-token-error.util.ts
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...erver/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
Dismissed
Show dismissed
Hide dismissed
...erver/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
Dismissed
Show dismissed
Hide dismissed
...erver/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
Dismissed
Show dismissed
Hide dismissed
...erver/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
Dismissed
Show dismissed
Hide dismissed
...erver/src/modules/messaging/message-import-manager/drivers/gmail/mocks/gaxios-error-mocks.ts
Dismissed
Show dismissed
Hide dismissed
ijreilly
approved these changes
Dec 5, 2024
...odules/messaging/message-import-manager/drivers/gmail/services/gmail-handle-error.service.ts
Outdated
Show resolved
Hide resolved
...odules/messaging/message-import-manager/drivers/gmail/services/gmail-handle-error.service.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8733
GmailHandleErrorService