Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapping text side effects #8895

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fix wrapping text side effects #8895

merged 2 commits into from
Dec 5, 2024

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Dec 5, 2024

  • ellipsis on the letter level instead of work level
  • summaryCard title line-height diffferent from the record line-height

@guillim guillim requested a review from lucasbordeau December 5, 2024 10:55
@guillim guillim self-assigned this Dec 5, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses text wrapping and line-height inconsistencies between summary cards and records, focusing on improved text overflow handling and consistent display behavior.

  • Added isDisplayModeFixHeight boolean flag in /packages/twenty-front/src/modules/object-record/record-field/contexts/FieldContext.ts to control fixed height display mode
  • Split text overflow handling in /packages/twenty-ui/src/display/tooltip/OverflowingTextWithTooltip.tsx into separate components for multiline and single-line text
  • Implemented consistent line heights (18px vs 24px) in /packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContainer.tsx
  • Modified text ellipsis to work at letter level instead of word level for better space utilization

5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@twentyhq twentyhq deleted a comment from greptile-apps bot Dec 5, 2024
@guillim
Copy link
Contributor Author

guillim commented Dec 5, 2024

fixes #8892

Copy link
Contributor

@lucasbordeau lucasbordeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guillim guillim merged commit 6c78cac into main Dec 5, 2024
19 checks passed
@guillim guillim deleted the fix-wraptext branch December 5, 2024 13:43
Copy link

github-actions bot commented Dec 5, 2024

Thanks @guillim for your contribution!
This marks your 15th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants