Refetch aggregate queries on record creation/update/deletion of record #8885
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds functionality to refetch aggregate queries after record operations, since aggregate values cannot be computed optimistically in the cache like regular queries.
- Added new
useRefetchAggregateQuerieshook in/packages/twenty-front/src/modules/object-record/hooks/useRefetchAggregateQueries.tsto centralize aggregate query refetching logic - Integrated refetch calls after mutations in record operation hooks (create/update/delete) to keep aggregate data in sync
- Potential issue:
useUpdateOneRecord.tshas duplicate refetch calls in both mutation update callback and completion - Added feature flag
IS_AGGREGATE_QUERY_ENABLEDto control aggregate functionality with proper fallbacks - Improved error handling needed in
useRefetchAggregateQueriesfor failed refetch operations
13 file(s) reviewed, 12 comment(s)
Edit PR Review Bot Settings | Greptile
| await refetchAggregateQueries(); | ||
| return createdObjects.data?.[mutationResponseField] ?? []; |
There was a problem hiding this comment.
style: consider wrapping refetch in try/catch to handle potential refetch failures gracefully
|
|
||
| await refetchAggregateQueries(); |
There was a problem hiding this comment.
logic: refetchAggregateQueries could fail silently here - consider handling errors or at least logging them
packages/twenty-front/src/modules/object-record/hooks/useDeleteManyRecords.ts
Show resolved
Hide resolved
| @@ -126,6 +131,7 @@ export const useDeleteOneRecord = ({ | |||
| throw error; | |||
| }); | |||
|
|
|||
| await refetchAggregateQueries(); | |||
There was a problem hiding this comment.
style: refetchAggregateQueries() should be wrapped in a try/catch to handle potential refetch failures gracefully
| export const useRefetchAggregateQueries = ({ | ||
| objectMetadataNamePlural, | ||
| }: { | ||
| objectMetadataNamePlural: string; |
There was a problem hiding this comment.
logic: objectMetadataNamePlural should be validated - getAggregateQueryName will throw if this is empty
packages/twenty-front/src/modules/object-record/hooks/useUpdateOneRecord.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/useUpdateOneRecord.ts
Outdated
Show resolved
Hide resolved
...ard/record-board-column/components/RecordBoardColumnHeaderAggregateDropdownFieldsContent.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/utils/getAggregateQueryName.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/utils/getAggregateQueryName.ts
Outdated
Show resolved
Hide resolved
| @@ -141,6 +146,7 @@ export const useCreateManyRecords = < | |||
| throw error; | |||
| }); | |||
|
|
|||
| await refetchAggregateQueries(); | |||
There was a problem hiding this comment.
this will seek to refetch aggregate queries even if there were no AggregateQueries performed before (like on table view for instance). I think it's ok but it does trigger a warning (yellow) in the console.
There was a problem hiding this comment.
@charlesBochet fyi
|
Nice |
Closes #8755.
Refetching the aggregate queries on an object following creation, update, deletion of a record.