review(): from PR #8656 #8870
Merged
review(): from PR #8656 #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUpForm.ts # packages/twenty-server/src/engine/core-modules/domain-manager/service/domain-manager.service.ts
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements significant changes to the authentication system, focusing on SSO integration, workspace-specific auth providers, and improved validation handling across both frontend and backend.
- Introduces new
SignInUpWorkspaceScopeFormEffectcomponent to handle automatic auth provider selection and form progression - Moves favicon handling from
WorkspaceProviderEffectto new dedicatedPageFaviconcomponent for better separation of concerns - Refactors backend auth validation with new
WorkspaceAuthProvidertype andisAuthEnabledOrThrowmethod - Renames validation methods for consistency (e.g.,
assertIsExisttoassertIsDefinedOrThrow) and improves error handling - Contains a critical typo in method name
saveDefautWorkspaceIfUserHasAccessOrThrow(missing 'l') across multiple files
38 file(s) reviewed, 16 comment(s)
Edit PR Review Bot Settings | Greptile
...ges/twenty-front/src/modules/auth/sign-in-up/components/SignInUpWorkspaceScopeFormEffect.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+33
| const checkAuthProviders = useCallback(() => { | ||
| if ( | ||
| signInUpStep === SignInUpStep.Init && | ||
| !authProviders.google && | ||
| !authProviders.microsoft && | ||
| !authProviders.sso | ||
| ) { | ||
| return continueWithEmail(); | ||
| } | ||
|
|
||
| if (isDefined(email) && authProviders.password) { | ||
| return continueWithCredentials(); | ||
| } | ||
| }, [ |
There was a problem hiding this comment.
logic: checkAuthProviders could be called with stale email value since email is not in dependency array
...ges/twenty-front/src/modules/auth/sign-in-up/components/SignInUpWorkspaceScopeFormEffect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUpForm.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/page-favicon/PageFavicon.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/user/user.validate.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/user/services/user.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workspace/workspace.type.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workspace/workspace.validate.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workspace/workspace.validate.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| export type WorkspaceAuthProvider = 'google' | 'microsoft' | 'password'; | |||
There was a problem hiding this comment.
this should be in a types folder
charlesBochet
approved these changes
Dec 4, 2024
charlesBochet
approved these changes
Dec 5, 2024
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.