Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seed-demo command #8866

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix seed-demo command #8866

merged 1 commit into from
Dec 4, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Dec 4, 2024

Context

Fix seed demo command since we added a subdomain non-nullable column we needed to update the command to fill that info for the demo workspace

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds the required 'subdomain' field to the workspace seeding function to fix the seed-demo command after the subdomain column was made non-nullable.

  • Added 'subdomain' to column list and values in /packages/twenty-server/src/database/typeorm-seeds/core/demo/workspaces.ts with value 'demo' for demo workspace

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -18,6 +18,7 @@ export const seedWorkspaces = async (
'domainName',
'inviteHash',
'logo',
'subdomain',
'activationStatus',
])
.orIgnore()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: orIgnore() could silently fail if a workspace with this ID already exists but has different values. Consider if this is the desired behavior.

@Weiko Weiko merged commit c735026 into main Dec 4, 2024
19 checks passed
@Weiko Weiko deleted the c--fix-seed-demo-command branch December 4, 2024 10:24
mdrazak2001 pushed a commit to mdrazak2001/twenty that referenced this pull request Dec 4, 2024
## Context
Fix seed demo command since we added a subdomain non-nullable column we
needed to update the command to fill that info for the demo workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants