Fix message participant assignation bug #8857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a critical bug where removing an email from a person incorrectly linked all email participants to that person, by improving participant matching logic and query precision.
- Replaced string comparisons with TypeORM's
Equaloperator in/packages/twenty-server/src/modules/match-participant/match-participant.service.tsfor more precise handle matching - Removed unnecessary TypeOrmModule and FieldMetadataEntity dependencies from
/packages/twenty-server/src/modules/match-participant/match-participant.module.ts - Added proper null handling for person and workspaceMember fields in
unmatchParticipantsmethod - Improved participant unlinking logic to only affect participants with matching handles
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Dec 3, 2024
charlesBochet
deleted the
8846-bug-if-i-remove-the-email-of-a-person-all-the-email-participants-are-linked-to-that-person
branch
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8846