fix(environment): Make SSL variables optional #8843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, SSL_KEY_PATH and SSL_CERT_PATH were required if the SERVER_URL started with 'https'. This change makes these variables optional, allowing greater flexibility in dealing with SSL configurations. This update helps in scenarios where SSL paths are managed differently or not needed.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the SSL configuration validation in the environment variables, making SSL certificate paths optional rather than required when using HTTPS.
- Modified
environment-variables.tsto makeSSL_KEY_PATHandSSL_CERT_PATHoptional by removing conditional validation - Potential security concern: HTTPS servers could now run without proper SSL certificate validation
- Change provides more flexibility but removes enforcement of SSL certificates with HTTPS protocol
- Recommend adding documentation or validation warnings when HTTPS is used without SSL paths specified
- Consider adding runtime checks to ensure secure HTTPS configuration when certificates are missing
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
475
to
481
| @IsString() | ||
| @ValidateIf((env) => env.SERVER_URL.startsWith('https')) | ||
| @IsOptional() | ||
| SSL_KEY_PATH: string; | ||
|
|
||
| @IsString() | ||
| @ValidateIf((env) => env.SERVER_URL.startsWith('https')) | ||
| @IsOptional() | ||
| SSL_CERT_PATH: string; |
There was a problem hiding this comment.
style: Consider adding a warning when SERVER_URL uses HTTPS but SSL paths are not provided
Log |
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 4, 2024
Previously, SSL_KEY_PATH and SSL_CERT_PATH were required if the SERVER_URL started with 'https'. This change makes these variables optional, allowing greater flexibility in dealing with SSL configurations. This update helps in scenarios where SSL paths are managed differently or not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SSL_KEY_PATH and SSL_CERT_PATH were required if the SERVER_URL started with 'https'. This change makes these variables optional, allowing greater flexibility in dealing with SSL configurations. This update helps in scenarios where SSL paths are managed differently or not needed.