Display and update aggregate queries in kanban views #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements aggregate query functionality in kanban views, allowing users to perform operations like count, sum, and average on column data with a new dropdown UI system.
- Added
useAggregateQueryanduseAggregatehooks in/packages/twenty-front/src/modules/object-record/hooks/for handling aggregate operations and GraphQL queries - Implemented new dropdown components in
/packages/twenty-front/src/modules/dropdown/with generic type support for managing dropdown state and content - Added
RecordBoardColumnHeaderAggregateDropdowncomponent in/packages/twenty-front/src/modules/object-record/record-board/record-board-column/components/for aggregate operation selection - Added server-side support with new fields
kanbanAggregateOperationandkanbanAggregateOperationFieldMetadataIdin/packages/twenty-server/src/modules/view/standard-objects/view.workspace-entity.ts - Implemented utility functions in
/packages/twenty-front/src/modules/object-record/utils/for generating aggregate queries and determining available aggregations per field type
52 file(s) reviewed, 63 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/dropdown/components/Dropdown.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/dropdown/components/Dropdown.tsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,12 @@ | |||
| import { AggregateContentId } from '@/object-record/record-board/types/AggregateContentId'; | |||
| import { createContext } from 'vm'; | |||
There was a problem hiding this comment.
logic: incorrect import - should be from 'react' not 'vm'
packages/twenty-front/src/modules/dropdown/components/DropdownContext.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/dropdown/components/DropdownContext.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
77
to
83
| acc[`min${capitalize(field.name)}AmountMicros`] = { | ||
| type: GraphQLFloat, | ||
| description: `Minimal amount contained in the field ${field.name}`, | ||
| fromField: field.name, | ||
| fromSubField: 'amountMicros', | ||
| aggregateOperation: AGGREGATE_OPERATIONS.min, | ||
| }; |
There was a problem hiding this comment.
style: description uses 'Minimal' while NUMBER type uses 'Minimum' - should be consistent across all similar operations
...graphql/workspace-schema-builder/utils/get-available-aggregations-from-object-fields.util.ts
Show resolved
Hide resolved
...-server/src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/view/standard-objects/view.workspace-entity.ts
Show resolved
Hide resolved
Comment on lines
223
to
229
| @WorkspaceField({ | ||
| standardId: VIEW_STANDARD_FIELD_IDS.kanbanAggregateOperationFieldMetadataId, | ||
| type: FieldMetadataType.TEXT, | ||
| label: 'Field metadata used for aggregate operation', | ||
| description: 'Field metadata used for aggregate operation', | ||
| defaultValue: null, | ||
| }) |
There was a problem hiding this comment.
style: using FieldMetadataType.TEXT for an ID field - should probably be UUID type like objectMetadataId
Weiko
reviewed
Dec 2, 2024
packages/twenty-front/src/modules/dropdown/components/Dropdown.tsx
Outdated
Show resolved
Hide resolved
...c/modules/object-record/record-board/record-board-column/hooks/useAggregateQueryForColumn.ts
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Dec 2, 2024
packages/twenty-server/src/modules/view/standard-objects/view.workspace-entity.ts
Show resolved
Hide resolved
|
Bravo Marie, super cool feature! 🤩 |
lucasbordeau
reviewed
Dec 3, 2024
lucasbordeau
reviewed
Dec 3, 2024
packages/twenty-front/src/modules/object-record/graphql/types/RecordGqlConnection.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/useAggregate.ts
Outdated
Show resolved
Hide resolved
...front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdown.tsx
Show resolved
Hide resolved
...s/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useOptionsDropdown.ts
Show resolved
Hide resolved
...ges/twenty-front/src/modules/object-record/utils/getAvailableAggregationsFromObjectFields.ts
Show resolved
Hide resolved
...ty-front/src/modules/object-record/utils/getAvailableFieldsForAggregationFromObjectFields.ts
Outdated
Show resolved
Hide resolved
...ty-front/src/modules/object-record/utils/getAvailableFieldsForAggregationFromObjectFields.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/hooks/useUpdateViewAggregate.ts
Outdated
Show resolved
Hide resolved
...wenty-server/src/engine/api/graphql/graphql-query-runner/helpers/process-aggregate.helper.ts
Outdated
Show resolved
Hide resolved
lucasbordeau
approved these changes
Dec 3, 2024
Weiko
force-pushed
the
aggregate-queries-front
branch
from
0fd5f74 to
4d7c681
Compare
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 4, 2024
Closes twentyhq#8752, twentyhq#8753, twentyhq#8754 Implements usage of aggregate queries in kanban views. https://github.com/user-attachments/assets/732590ca-2785-4c57-82d5-d999a2279e92 TO DO 1. write tests + storybook 2. Fix values displayed should have the same format as defined in number fields + Fix display for amountMicros --------- Co-authored-by: Weiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8752, #8753, #8754
Implements usage of aggregate queries in kanban views.
https://github.com/user-attachments/assets/732590ca-2785-4c57-82d5-d999a2279e92
TO DO