Fix Make Postgres on Docker #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the Makefile to fix PostgreSQL initialization hanging issues by executing commands directly within the Docker container context instead of through the host machine.
- Modified
postgres-on-dockertarget in/Makefileto executepsqlcommands directly inside container usingdocker exec twenty_pg - Removed host connection parameters (
-h localhost,-p 5432) since commands now run inside container - Removed
PGPASSWORDenvironment variable as authentication happens within container context - Added container readiness check using
pg_is_in_recovery()to ensure proper initialization
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+11
to
14
| @until docker exec twenty_pg psql -U postgres -d postgres \ | ||
| -c 'SELECT pg_is_in_recovery();' 2>/dev/null | grep -q 'f'; do \ | ||
| sleep 1; \ | ||
| done |
There was a problem hiding this comment.
style: Consider adding a timeout to prevent infinite waiting if PostgreSQL fails to start properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8630