CSV importing and exporting fixes #8824
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances CSV import/export functionality for multi-select and RAW_JSON fields in Twenty's object record system.
- Added JSON string parsing for multi-select/array fields in
buildRecordFromImportedStructuredRow.tswith fallback to empty array - Added RAW_JSON field handling in
useExportProcessRecordsForCSV.tsto properly stringify JSON content for export - Added Zod schema validation for array/multi-select fields during import to ensure data integrity
- Added proper error handling for malformed JSON input during import operations
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| default: | ||
| return processedRecord; | ||
| } |
There was a problem hiding this comment.
logic: The default case drops the field value entirely by returning unmodified record. This breaks the export of multi-select fields, which was the main issue to fix.
| if (!isDefined(record[field.name])) { | ||
| return processedRecord; | ||
| } |
There was a problem hiding this comment.
style: Early return for undefined values means null values will be excluded from CSV export. Consider if this is the desired behavior.
| const stringArrayJSONSchema = z | ||
| .preprocess((value) => { | ||
| try { | ||
| if (typeof value !== 'string') { | ||
| return []; | ||
| } | ||
| return JSON.parse(value); | ||
| } catch { | ||
| return []; | ||
| } | ||
| }, z.array(z.string())) | ||
| .catch([]); |
There was a problem hiding this comment.
style: Consider handling comma-separated values as fallback when JSON parsing fails, to support both JSON array format and simple comma-separated values
| if (typeof importedFieldValue === 'string') { | ||
| try { | ||
| recordToBuild[field.name] = JSON.parse(importedFieldValue); | ||
| } catch { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
style: Should validate the parsed JSON structure matches expected schema before assigning to recordToBuild
|
Please ignore previous comment, I wasn't on the right branch 🤦♂️ |
|
Great! How are would it be to add a matching space, as we do for the Select field already? I think it would be best to have a consistent experience between the 2 field types
(Note array fields are different because they can take any target value so no mapping is needed) |
|
1 test to be fixed :) |
|
You know what, let's merge like that @eliasylonen - but could you do please do a followup with multi-select-matching or just create an issue for it if it's too complex? Thanks! |
There was a problem hiding this comment.
@eliasylonen could you please merge once tests are fixed? Thanks!
|
Great!!! |
|
Thanks @eliasylonen for your contribution! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Fixes issue #5793 (and duplicate #8822)