Implement contextual actions for the workflows #8814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extual-actions-for-the-workflows
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements comprehensive workflow management functionality through contextual actions in the action menu system. Here's a summary of the key changes:
- Added workflow-specific actions (test, activate/deactivate, draft management) with proper state handling and user feedback
- Implemented workflow version management actions (use as draft, view history, executions) with navigation support
- Created new hooks for workflow operations with proper cleanup and state management
- Added confirmation modals for destructive actions like discarding drafts
- Added success notifications with icons for workflow execution status
Key points to review:
- Error handling is missing in several workflow action hooks
- Potential race conditions in state management between workflow and version loading
- Some hooks have inconsistent logic in onClick handlers (e.g., deactivate workflow)
- No loading states implemented for async operations
- Position parameters could benefit from centralized constants instead of hardcoded values
36 file(s) reviewed, 36 comment(s)
Edit PR Review Bot Settings | Greptile
.../src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx
Outdated
Show resolved
Hide resolved
...ules/action-menu/actions/record-actions/multiple-records/hooks/useMultipleRecordsActions.tsx
Outdated
Show resolved
Hide resolved
...ules/action-menu/actions/record-actions/multiple-records/hooks/useMultipleRecordsActions.tsx
Show resolved
Hide resolved
...n-menu/actions/record-actions/single-record/components/SingleRecordActionMenuEntrySetter.tsx
Outdated
Show resolved
Hide resolved
...n-menu/actions/record-actions/single-record/components/SingleRecordActionMenuEntrySetter.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/hooks/useActiveWorkflowVersion.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/hooks/useActiveWorkflowVersion.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/hooks/useActiveWorkflowVersion.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/hooks/useRunWorkflowVersion.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/hooks/useRunWorkflowVersion.tsx
Show resolved
Hide resolved
…extual-actions-for-the-workflows
…ub.com:twentyhq/twenty into implement-contextual-actions-for-the-workflows
martmull
reviewed
Dec 3, 2024
.../src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx
Outdated
Show resolved
Hide resolved
.../src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx
Outdated
Show resolved
Hide resolved
...n-menu/actions/record-actions/single-record/components/SingleRecordActionMenuEntrySetter.tsx
Show resolved
Hide resolved
.../workflow-actions/hooks/useActivateWorkflowLastPublishedVersionWorkflowSingleRecordAction.ts
Show resolved
Hide resolved
...ions/single-record/workflow-actions/hooks/useDeactivateWorkflowWorkflowSingleRecordAction.ts
Outdated
Show resolved
Hide resolved
...rd-actions/single-record/workflow-actions/hooks/useDiscardDraftWorkflowSingleRecordAction.ts
Show resolved
Hide resolved
...s/single-record/workflow-actions/hooks/useSeeWorkflowExecutionsWorkflowSingleRecordAction.ts
Outdated
Show resolved
Hide resolved
...s/single-record/workflow-actions/hooks/useSeeWorkflowExecutionsWorkflowSingleRecordAction.ts
Outdated
Show resolved
Hide resolved
...rd-actions/single-record/workflow-actions/hooks/useTestWorkflowWorkflowSingleRecordAction.ts
Outdated
Show resolved
Hide resolved
thomtrp
reviewed
Dec 3, 2024
.../src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx
Outdated
Show resolved
Hide resolved
bosiraphael
deleted the
implement-contextual-actions-for-the-workflows
branch
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 4, 2024
Implemented the following actions for the workflows: - Test Workflow - Discard Draft - Activate Draft - Activate Workflow Last Published Version - Deactivate Workflow - See Workflow Executions - See Workflow Active Version - See Workflow Versions History And the following actions for the workflow versions: - Use As Draft - See Workflow Versions History - See Workflow Executions Video example: https://github.com/user-attachments/assets/016956a6-6f2e-4de5-9605-d6e14526cbb3 A few of these actions are links to the relations of the workflow object (link to a filtered table). To generalize this behavior, I will create an hook named `useSeeRelationsActionSingleRecordAction` to automatically generate links to a showPage if the relation is a Many To One or to a filtered table if the relation is a One to Many for all the record types. I will also create actions which will allow to create a relation. --------- Co-authored-by: Charles Bochet <[email protected]>
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the following actions for the workflows:
And the following actions for the workflow versions:
Video example:
Enregistrement.de.l.ecran.2024-11-29.a.16.38.20.mov
A few of these actions are links to the relations of the workflow object (link to a filtered table). To generalize this behavior, I will create an hook named
useSeeRelationsActionSingleRecordActionto automatically generate links to a showPage if the relation is a Many To One or to a filtered table if the relation is a One to Many for all the record types.I will also create actions which will allow to create a relation.