Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render IconFolderOpen when folder is open #8811

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ehconitin
Copy link
Contributor

closes #8809

2024-11-29.19-58-50.mov

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added visual feedback for folder open/closed states in the favorites navigation drawer by implementing dynamic folder icons.

  • Added conditional rendering of IconFolderOpen vs IconFolder based on isOpen state in /packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsx
  • Added IconFolderOpen export to /packages/twenty-ui/src/display/icon/components/TablerIcons.ts to support the new open folder visual state

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Nice little detail

@FelixMalfait FelixMalfait merged commit a7bbc9e into twentyhq:main Nov 29, 2024
17 checks passed
Copy link

Thanks @ehconitin for your contribution!
This marks your 63rd PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the folder icon when the folder is opened
2 participants