8723 workflow add editor in serverless function code step #8805

martmull · 2024-11-29T09:12:32Z

create a serverless function when creating a new workflow code step
add code editor in workflow code step
move workflowVersion steps management from frontend to backend
- add a custom resolver for workflow-version management
- fix optimistic rendering on frontend
fix css
delete serverless function when deleting workflow code step

TODO

Don't update serverlessFunction if no code change
Factorize what can be between crud trigger and crud step
Publish serverless version when activating workflow
delete serverless functions when deleting workflow or workflowVersion
fix optimistic rendering for code updates
Unify CRUD types

…ages

…ion-code-step

greptile-apps

PR Summary

This PR implements serverless function code editing in workflow steps and moves workflow version step management from frontend to backend, with significant changes to both the UI and backend architecture.

Added new WorkflowVersionResolver and DTOs in backend to handle workflow step CRUD operations through dedicated endpoints
Implemented code editor integration in WorkflowEditActionFormServerlessFunction with Monaco editor and auto-completion support
Added serverless function lifecycle management (create/delete) tied to workflow code steps
Created DeleteServerlessFunctionJob for batch deletion through message queue system
Refactored workflow action types to simplify CRUD operations by consolidating subtypes into single RECORD_CRUD type

_{56 file(s) reviewed, 52 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2024-11-29T09:16:31Z

...tion-menu/actions/global-actions/workflow-run-actions/components/WorkflowRunActionEffect.tsx

@@ -35,7 +35,7 @@ export const WorkflowRunActionEffect = () => {
        type: ActionMenuEntryType.WorkflowRun,
        key: `workflow-run-${activeWorkflowVersion.id}`,
        scope: ActionMenuEntryScope.Global,
-        label: capitalize(activeWorkflowVersion.workflow.name),
+        label: capitalize(activeWorkflowVersion.workflow?.name || ''),


logic: Optional chaining added for workflow?.name but not used consistently - line 48 still accesses workflow.name directly which could cause runtime errors

greptile-apps · 2024-11-29T09:17:11Z

packages/twenty-front/src/modules/object-record/hooks/useLazyFindOneRecord.ts

+    findOneRecord: async ({
+      objectRecordId,
+      onCompleted,
+    }: FindOneRecordParams<T>) => {
+      await findOneRecord({
        variables: { objectRecordId },
+        fetchPolicy,
        onCompleted: (data) => {
          const record = getRecordFromRecordNode<T>({
            recordNode: data[objectNameSingular],
          });
          onCompleted?.(record);
        },
-      }),
+      });
+    },


logic: Making findOneRecord async but not handling potential rejection could cause unhandled promise rejections. Consider adding try/catch.

greptile-apps · 2024-11-29T09:17:49Z

...rc/modules/settings/serverless-functions/components/SettingsServerlessFunctionCodeEditor.tsx

+  const { serverlessFunctionId = '' } = useParams();
+  const { availablePackages } = useGetAvailablePackages({
+    id: serverlessFunctionId,
+  });


logic: serverlessFunctionId defaults to empty string which could cause issues if ID is required by useGetAvailablePackages

greptile-apps · 2024-11-29T09:19:35Z

...ages/twenty-front/src/modules/settings/serverless-functions/hooks/useGetAvailablePackages.ts

 } from '~/generated-metadata/graphql';

-export const useGetAvailablePackages = () => {
+export const useGetAvailablePackages = (input: ServerlessFunctionIdInput) => {


style: Consider making input parameter optional with a default value to maintain backward compatibility with existing usage

...ages/twenty-front/src/modules/settings/serverless-functions/hooks/useGetAvailablePackages.ts

...ty-server/src/modules/workflow/workflow-status/listeners/workflow-version-status.listener.ts

packages/twenty-ui/src/input/code-editor/components/CodeEditor.tsx

…ion-code-step

thomtrp

Huge work @martmull 💪

packages/twenty-front/src/modules/workflow/components/WorkflowDiagramStepNodeEditable.tsx

...wenty-server/src/engine/core-modules/workflow/dtos/create-workflow-version-step-input.dto.ts

packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow-version.resolver.ts

...-server/src/modules/workflow/common/workspace-services/workflow-version.workspace-service.ts

packages/twenty-ui/src/input/code-editor/components/CodeEditor.tsx

…ion-code-step

packages/twenty-front/src/modules/object-record/hooks/useLazyFindOneRecord.ts

...er/src/modules/workflow/common/workspace-services/workflow-version-step.workspace-service.ts

Devessier

Thank you a lot for your pull request, @martmull. It's really nice to edit a serverless function directly from the workflow visualizer.

I spotted a few things that we could discuss.

...on-menu/actions/record-agnostic-actions/workflow-run-actions/hooks/useWorkflowRunActions.tsx

packages/twenty-front/src/modules/workflow/hooks/useCreateNewWorkflowVersion.ts

packages/twenty-front/src/modules/workflow/hooks/useUpdateWorkflowVersionStep.ts

packages/twenty-front/src/modules/workflow/hooks/useWorkflowWithCurrentVersion.ts

packages/twenty-front/src/modules/workflow/utils/getFunctionInputSchema.ts

...wenty-server/src/engine/core-modules/serverless/drivers/utils/get-last-layer-dependencies.ts

...er/src/modules/workflow/common/workspace-services/workflow-version-step.workspace-service.ts

...rc/modules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunction.tsx

) - create a serverless function when creating a new workflow code step - add code editor in workflow code step - move workflowVersion steps management from frontend to backend - add a custom resolver for workflow-version management - fix optimistic rendering on frontend - fix css - delete serverless function when deleting workflow code step TODO - Don't update serverlessFunction if no code change - Factorize what can be between crud trigger and crud step - Publish serverless version when activating workflow - delete serverless functions when deleting workflow or workflowVersion - fix optimistic rendering for code updates - Unify CRUD types <img width="1279" alt="image" src="https://github.com/user-attachments/assets/3d97ee9f-4b96-4abc-9d36-5c0280058be4">

martmull added 10 commits November 26, 2024 16:42

Create serverless function if not exists

d5c63aa

Remove select serverless function from rightDrawer

bf9f7e1

Add codeEditor

6f6b599

Update getAvailablePackages so it gets serverless function layer pack…

b4dd9fb

…ages

Simplify code Editor style

5260048

Move step update from front to back

21116ca

Fix step code update

c583657

Fix step title design

6ce641a

Fix bug

96620bd

Delete Serverless Function when deleting step

1030742

martmull linked an issue Nov 29, 2024 that may be closed by this pull request

[Workflow] Add editor in serverless function code step #8723

Closed

Merge branch 'main' into 8723-workflow-add-editor-in-serverless-funct…

2986c13

…ion-code-step

greptile-apps bot reviewed Nov 29, 2024

View reviewed changes

charlesBochet added the -PR: awaiting review label Nov 29, 2024

charlesBochet assigned martmull Nov 29, 2024

martmull added 10 commits November 29, 2024 13:05

Improve optimistic rendering

ac2c561

Remove useless return

66723e4

Fix wrong import

c84a6a8

Remove useless stuff

cf1778e

Remove useless test

e34afdb

Fix

dcda7d1

Merge branch 'main' into 8723-workflow-add-editor-in-serverless-funct…

56e31f4

…ion-code-step

Remove code introspection listener

db3b132

Move and use instropection service to frontend

8277cc5

Fix bug

98c4770

thomtrp reviewed Nov 29, 2024

View reviewed changes

Fix variables for serverless functions

5d36f1c

martmull force-pushed the 8723-workflow-add-editor-in-serverless-function-code-step branch from 99f8f19 to 5d36f1c Compare November 29, 2024 16:44

martmull added 2 commits November 29, 2024 23:41

Add back old typing

ebf0857

Merge branch 'main' into 8723-workflow-add-editor-in-serverless-funct…

b3d31cf

…ion-code-step

Code review returns: specific exceptions

be26ee6

thomtrp reviewed Dec 2, 2024

View reviewed changes

martmull force-pushed the 8723-workflow-add-editor-in-serverless-function-code-step branch from 5f598a0 to 42673fc Compare December 2, 2024 10:39

Fix test

ecf5e2d

martmull force-pushed the 8723-workflow-add-editor-in-serverless-function-code-step branch from 42673fc to ecf5e2d Compare December 2, 2024 10:43

Devessier reviewed Dec 2, 2024

View reviewed changes

martmull added 6 commits December 2, 2024 11:50

Code review returns: Thomas

3857fba

Code review returns: Baptiste

ce90e5c

Code review returns: Baptiste

b844113

Code review returns: Baptiste

963477e

Lazy load editActionForm

9cedd14

Fix missing workflow error

da61cfe

thomtrp approved these changes Dec 2, 2024

View reviewed changes

martmull added 4 commits December 2, 2024 18:13

Fix import

2dca1dc

Fix sckeleton loader

3d2eaca

Refacto

14468eb

Fix delete trigger

4fc5f58

martmull force-pushed the 8723-workflow-add-editor-in-serverless-function-code-step branch 2 times, most recently from 07703e8 to 11b0ea1 Compare December 2, 2024 21:23

Add test

3382033

martmull force-pushed the 8723-workflow-add-editor-in-serverless-function-code-step branch from 11b0ea1 to 3382033 Compare December 2, 2024 21:41

martmull enabled auto-merge (squash) December 2, 2024 21:47

martmull disabled auto-merge December 2, 2024 21:47

Fix storybook memory error

f5fae0b

martmull enabled auto-merge (squash) December 2, 2024 22:06

Fix storybook test

11c1dc4

martmull merged commit d0ff1ff into main Dec 3, 2024
19 checks passed

martmull deleted the 8723-workflow-add-editor-in-serverless-function-code-step branch December 3, 2024 08:41

martmull mentioned this pull request Dec 6, 2024

[Workflow] Move input schema inference from back to front #8724

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8723 workflow add editor in serverless function code step #8805

8723 workflow add editor in serverless function code step #8805

martmull commented Nov 29, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

thomtrp left a comment

Devessier left a comment

8723 workflow add editor in serverless function code step #8805

8723 workflow add editor in serverless function code step #8805

Conversation

martmull commented Nov 29, 2024 • edited Loading

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

thomtrp left a comment

Choose a reason for hiding this comment

Devessier left a comment

Choose a reason for hiding this comment

martmull commented Nov 29, 2024 •

edited

Loading