Don't show summary/fields on workflow record pages #8804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the record show page layout to hide summary and fields sections specifically for workflow record pages, while raising concerns about title editing functionality that will need to be addressed.
- Added
hideSummaryAndFieldsflag toRecordLayouttype to control visibility of left column sections - Modified
useRecordShowContainerTabsto support workflow-specific layout with hidden summary/fields - Updated
ShowPageSubContainerto conditionally render summary/fields based on layout settings - Introduced
RecordLayoutMaptype for mapping string keys toRecordLayoutobjects - Refactored tab visibility logic in
TabListto handle cases with fewer visible tabs
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding the left column on workflow pages
This raises additional questions: how do we edit the title then? Probably need a significant refacto of PageHeader