Add a few tests on workflow hooks #8800
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added test coverage for three workflow hooks, focusing on basic functionality verification of schema computation, workflow version creation, and step creation processes.
- Test for
useComputeStepOutputSchemain/packages/twenty-front/src/modules/workflow/hooks/__tests__/useComputeStepOutputSchema.test.tsneeds error handling scenarios - Test for
useCreateNewWorkflowVersionin/packages/twenty-front/src/modules/workflow/hooks/__tests__/useCreateNewWorkflowVersion.test.tsshould verify data structure integrity - Test for
useCreateStepin/packages/twenty-front/src/modules/workflow/hooks/__tests__/useCreateStep.test.tsshould validate mock function arguments and test non-draft version scenarios - Missing validation for edge cases where input parameters are invalid or undefined
- Tests should verify the integration between
computeStepOutputSchemaand step creation workflow
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| describe('useComputeStepOutputSchema', () => { | ||
| it('should compute schema successfully', async () => { | ||
| const mockInput = { stepId: '123' }; |
There was a problem hiding this comment.
logic: mockInput doesn't match implementation - useComputeStepOutputSchema expects a full step object, not just stepId
|
|
||
| const { result } = renderHook(() => useCreateNewWorkflowVersion()); | ||
| await result.current.createNewWorkflowVersion( | ||
| workflowVersionData as unknown as WorkflowVersion, |
There was a problem hiding this comment.
style: Double type assertion is unnecessary and could mask type errors. Consider defining proper types or using a single assertion.
| expect(mockUpdateOneWorkflowVersion).toHaveBeenCalled(); | ||
| expect(mockOpenRightDrawer).toHaveBeenCalled(); |
There was a problem hiding this comment.
style: Add expectations for the actual arguments passed to these mocked functions to ensure they're called with correct parameters
As title