Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Put workflow run actions behind feature flag #8798

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

bosiraphael
Copy link
Contributor

Fix: Put workflow run actions behind feature flag

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements feature flag control for workflow run actions, ensuring workflow-related functionality is only available when explicitly enabled.

  • Added feature flag check IS_WORKFLOW_ENABLED in /packages/twenty-front/src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx to conditionally render workflow actions
  • Created new component /packages/twenty-front/src/modules/action-menu/actions/record-actions/workflow-run-record-actions/components/WorkflowRunRecordActionMenuEntrySetter.tsx to handle workflow action registration
  • Removed workflow actions from useSingleRecordActions hook to maintain clean separation
  • Added conditional rendering of RecordAgnosticActionsSetterEffect in DefaultLayout.tsx based on workflow feature flag

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@Weiko Weiko merged commit 541bbb9 into main Nov 28, 2024
15 of 19 checks passed
@Weiko Weiko deleted the fix-put-workflow-run-actions-behind-feature-flag branch November 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants