Upgrade relation picker #8795
Merged
Upgrade relation picker #8795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
force-pushed
the
tt-refacto-relation-picker
branch
from
d6e13ae to
29b0fce
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR undertakes a significant refactoring effort to standardize terminology and improve state management in the relation picker components, replacing 'relation/entity' with 'record' and moving from scoped states to component-level state management.
- Replaces
RelationPickerScopewithRecordPickerComponentInstanceContext.Providerfor more direct state management - Introduces new component states (
recordPickerSearchFilterComponentState,recordPickerPreselectedIdComponentState) to replace scoped states - Renames
SingleEntitySelecttoSingleRecordSelectand related components for consistent terminology - Inconsistent naming remains in some files where 'relation' or 'entity' terms are still used (e.g.,
selectedEntitiesinRecordsForMultipleRecordSelect) - Potential issue with
instanceIdstill using 'relation-picker' value inRecordPickerDecorator
60 file(s) reviewed, 37 comment(s)
Edit PR Review Bot Settings | Greptile
...nty-front/src/modules/activities/inline-cell/components/ActivityTargetInlineCellEditMode.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-metadata/components/ObjectMetadataItemsProvider.tsx
Outdated
Show resolved
Hide resolved
...bject-record/record-board/record-board-column/components/RecordBoardColumnNewOpportunity.tsx
Outdated
Show resolved
Hide resolved
...enty-front/src/modules/object-record/record-board/record-board-column/hooks/useAddNewCard.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/utils/getRecordChipGenerators.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/search/hooks/__tests__/useFilteredSearchEntityQuery.test.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/search/hooks/useFilteredSearchEntityQuery.ts
Show resolved
Hide resolved
Comment on lines
+9
to
10
| // TODO: use this for all search queries, because we need selectedRecords and recordsToSelect each time we want to search | ||
| // Filtered entities to select are |
There was a problem hiding this comment.
style: comment still refers to 'entities' but should use 'records' terminology. Also line 10 appears to be an incomplete comment
packages/twenty-front/src/testing/decorators/RecordPickerDecorator.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/utils/getRecordChipGenerators.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/utils/getRecordChipGenerators.ts
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/object-record/relation-picker/hooks/useRecordPickerRecordsOptions.ts
Outdated
Show resolved
Hide resolved
...ages/twenty-front/src/modules/object-record/relation-picker/components/MultiRecordSelect.tsx
Show resolved
Hide resolved
...elation-picker/components/ActivityTargetInlineCellEditModeMultiRecordsSearchFilterEffect.tsx
Show resolved
Hide resolved
...ect-record/relation-picker/components/ActivityTargetInlineCellEditModeMultiRecordsEffect.tsx
Show resolved
Hide resolved
...rd/record-field/meta-types/input/components/RelationFromManyFieldInputMultiRecordsEffect.tsx
Show resolved
Hide resolved
thomtrp
force-pushed
the
tt-refacto-relation-picker
branch
from
414b586 to
dd73369
Compare
lucasbordeau
approved these changes
Nov 28, 2024
thomtrp
force-pushed
the
tt-refacto-relation-picker
branch
from
dd73369 to
47002be
Compare
thomtrp
force-pushed
the
tt-refacto-relation-picker
branch
from
47002be to
8baf160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the use of the record picker in workflows