Calendar event cursor flashes #8792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a visual glitch where the red cursor bar between calendar events was flashing during initial load by improving animation handling.
- Replaced CSS pseudo-element with new
StyledDotcomponent in/packages/twenty-front/src/modules/activities/calendar/components/CalendarCurrentEventCursor.tsx - Added explicit opacity animations with delays to control cursor appearance
- Wrapped dot element in
motion.divfor smoother animation control - Simplified cursor styling by removing pseudo-element complexity
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+171
to
+174
| transition={{ | ||
| delay: theme.animation.duration.normal, | ||
| duration: theme.animation.duration.normal, | ||
| }} |
There was a problem hiding this comment.
style: Consider using theme.animation.delay.normal for consistency with other theme values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4692
This is not the most beautiful fix (I think the right fix is to add 1px somewhere), but this issue is old and deserved to be closed quickly without spending too much time as this will likely be refactored and is not very important