feat: table record group #8781
Merged
feat: table record group #8781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magrinj
force-pushed
the
feat/table-record-group
branch
2 times, most recently
from
b4acc66 to
b9200de
Compare
...ty-front/src/modules/object-record/record-index/states/recordIndexAllRowIdsComponentState.ts
Show resolved
Hide resolved
...ules/object-record/record-index/states/selectors/recordIndexAllRecordIdsComponentSelector.ts
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/object-record/record-table/components/RecordTableRecordGroupRows.tsx
Outdated
Show resolved
Hide resolved
...cord/record-table/record-table-body/components/RecordTableBodyRecordGroupDragDropContext.tsx
Outdated
Show resolved
Hide resolved
...cord/record-table/record-table-body/components/RecordTableBodyRecordGroupDragDropContext.tsx
Outdated
Show resolved
Hide resolved
...ules/object-record/record-table/record-table-body/components/RecordTableRecordGroupsBody.tsx
Outdated
Show resolved
Hide resolved
...src/modules/object-record/record-table/record-table-row/components/RecordTableRowWrapper.tsx
Outdated
Show resolved
Hide resolved
...object-record/record-table/record-table-section/components/RecordTableRecordGroupSection.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const StyledRecordGroupSection = styled.td` | ||
| border-bottom: 1px solid ${({ theme }) => theme.border.color.light}; | ||
| padding-bottom: 6px; |
There was a problem hiding this comment.
use theme here (I'm a bit surprised by the 6px value, is this in Figma?
We usually have a 4px scale for paddings
There was a problem hiding this comment.
Yes it's what I have on Figma, strange
...ct-record/record-table/states/selectors/numberOfTableRowIdsByGroupComponentFamilySelector.ts
Outdated
Show resolved
Hide resolved
...s/object-record/record-table/states/selectors/numberOfVisibleTableColumnComponentSelector.ts
Outdated
Show resolved
Hide resolved
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements record grouping functionality for tables, allowing rows to be grouped, collapsed/expanded, and reordered similar to the board view functionality.
- Added
RecordTableRecordGroupSectioncomponent with collapsible sections and group headers in/packages/twenty-front/src/modules/object-record/record-table/record-table-section/components/RecordTableRecordGroupSection.tsx - Replaced
recordIndexAllRowIdsComponentStatewithrecordIndexAllRecordIdsComponentSelectoracross components for consistent record ID management - Added drag-and-drop support for record reordering within groups via
RecordTableBodyRecordGroupDragDropContext - Implemented group visibility toggle state with
isRecordGroupTableSectionToggledComponentState - Added animation support via Framer Motion (noted as not working yet) in
RecordTableRecordGroupRows
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
38 file(s) reviewed, 32 comment(s)
Edit PR Review Bot Settings | Greptile
.../src/modules/object-record/record-board/record-board-column/components/RecordBoardColumn.tsx
Show resolved
Hide resolved
...object-record/record-board/states/selectors/recordBoardSelectedRecordIdsComponentSelector.ts
Show resolved
Hide resolved
...ty-front/src/modules/object-record/record-index/states/recordIndexAllRowIdsComponentState.ts
Show resolved
Hide resolved
...ules/object-record/record-index/states/selectors/recordIndexAllRecordIdsComponentSelector.ts
Outdated
Show resolved
Hide resolved
...ules/object-record/record-index/states/selectors/recordIndexAllRecordIdsComponentSelector.ts
Show resolved
Hide resolved
...odules/object-record/record-table/states/selectors/allRowsSelectedStatusComponentSelector.ts
Show resolved
Hide resolved
...s/object-record/record-table/states/selectors/numberOfVisibleTableColumnComponentSelector.ts
Outdated
Show resolved
Hide resolved
...s/object-record/record-table/states/selectors/numberOfVisibleTableColumnComponentSelector.ts
Outdated
Show resolved
Hide resolved
...t/src/modules/object-record/record-table/states/selectors/selectedRowIdsComponentSelector.ts
Show resolved
Hide resolved
...src/modules/object-record/record-table/states/selectors/unselectedRowIdsComponentSelector.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/useCreateOneRecord.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/useCreateOneRecord.ts
Outdated
Show resolved
Hide resolved
...-record/object-options-dropdown/components/ObjectOptionsDropdownRecordGroupFieldsContent.tsx
Outdated
Show resolved
Hide resolved
...-record/object-options-dropdown/components/ObjectOptionsDropdownRecordGroupFieldsContent.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/utils/addDefaultValueRecordInput.ts
Outdated
Show resolved
Hide resolved
magrinj
force-pushed
the
feat/table-record-group
branch
from
be8df9e to
9d2254d
Compare
charlesBochet
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8401 #8402
This PR is only taking care or displaying properly the record group on the table.
Record-reorder within group has also been prepared.
Start of collapsible animation has been done, but not working for now.