Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8764 incorrect email sorting #8768

Merged
merged 2 commits into from
Nov 27, 2024
Merged

8764 incorrect email sorting #8768

merged 2 commits into from
Nov 27, 2024

Conversation

bosiraphael
Copy link
Contributor

Closes #8764

@bosiraphael bosiraphael linked an issue Nov 26, 2024 that may be closed by this pull request
@FelixMalfait FelixMalfait self-requested a review November 26, 2024 20:21
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you! Do you think we could simplify and just merge the two requests in one? I don't see why it wouldn't be possible but maybe I'm missing something. Feel free to merge after

@bosiraphael
Copy link
Contributor Author

bosiraphael commented Nov 27, 2024

We can't merge the two requests because the filter

 where: {
          messages: {
            messageParticipants: {
              personId: Any(personIds),
            },
          },
        },

would apply on both and we would get only the personIds in the messageParticipants and not the other messageParticipants

@bosiraphael bosiraphael merged commit 0d6a6ec into main Nov 27, 2024
19 checks passed
@bosiraphael bosiraphael deleted the 8764-incorrect-email-sorting branch November 27, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect email sorting
2 participants