Fix custom object renaming

[ijreilly]

Currently when renaming an object, we execute

await this.fieldMetadataRepository
                    .findOneByOrFail({
                      name: existingObjectMetadata.nameSingular,
                      label: existingObjectMetadata.labelSingular,
                      objectMetadataId: relatedObject.id,
                      workspaceId: workspaceId,
                    })

to find the standard relation fields.
This would throw an error if the label solely was update beforehand without updating the name too: in that case we will not have migrated the label of the standard relation fields (which is maybe a mistake? @Weiko wdyt?).
Let's remove it.

[greptile-apps]

PR Summary

This PR modifies the object renaming functionality by removing the label check when finding standard relation fields, addressing an issue where renaming would fail if labels were updated independently of names.

• Modified createStandardRelationsUpdatesMigrations in /packages/twenty-server/src/engine/metadata-modules/object-metadata/services/object-metadata-migration.service.ts to remove label condition from findOneByOrFail query
• Potential risk: Removing label check could cause ambiguity if multiple fields share the same name with different labels
• Consider adding validation to prevent duplicate field names within the same object context

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}