Gmail error handling fixes #8732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances Gmail message import error handling by improving error code detection, message extraction, and sync stage accuracy across multiple services.
- Modified error code detection in
/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/services/gmail-handle-error.service.tsto useerror.codeinstead oferror.response.status - Added proper error message extraction from both direct error objects and response data in Gmail error handling
- Replaced calendar-specific constant with
MESSAGING_THROTTLE_MAX_ATTEMPTSfor message import throttling - Fixed refresh token exception handling syntax in
/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts - Updated sync step from
PARTIAL_MESSAGE_LIST_FETCHtoMESSAGES_IMPORTfor accurate error stage tracking
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...odules/messaging/message-import-manager/drivers/gmail/services/gmail-handle-error.service.ts
Show resolved
Hide resolved
charlesBochet
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gmail error handling fixes