add delete view fields without views command #8728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds commands to clean up orphaned view fields and enforce data integrity constraints, focusing on making viewId non-nullable and updating cascade behaviors.
Key changes:
- Added
DeleteViewFieldsWithoutViewsCommandto remove view fields with null viewId - Changed
onDeleteaction fromSET_NULLtoCASCADEfor viewFields inViewWorkspaceEntity - Added unique index on
[fieldMetadataId, viewId]inViewFieldWorkspaceEntity - Added
onDelete: SET_NULLaction for favorites relation inFavoriteFolderWorkspaceEntity - Made
viewIdfield non-nullable inViewFieldWorkspaceEntity
8 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
.../src/database/commands/upgrade-version/0-33/0-33-delete-view-fields-without-views.command.ts
Show resolved
Hide resolved
.../src/database/commands/upgrade-version/0-33/0-33-delete-view-fields-without-views.command.ts
Show resolved
Hide resolved
.../src/database/commands/upgrade-version/0-33/0-33-delete-view-fields-without-views.command.ts
Show resolved
Hide resolved
Comment on lines
+38
to
+42
| await this.deleteViewFieldsWithoutViewsCommand.executeActiveWorkspacesCommand( | ||
| passedParam, | ||
| options, | ||
| workspaceIds, | ||
| ); |
There was a problem hiding this comment.
style: Consider adding error handling here to prevent upgrade failure if view field cleanup fails
...enty-server/src/modules/favorite-folder/standard-objects/favorite-folder.workspace-entity.ts
Show resolved
Hide resolved
charlesBochet
approved these changes
Nov 26, 2024
Weiko
added a commit
that referenced
this pull request
Nov 26, 2024
## Context We recently added a command to ensure uniqueness on the viewId column in the viewField table. This created some issues for some old workspaces that had viewFields with an empty viewId. This command should get rid of those and set the column as non-nullable. Also updating the onDelete action accordingly and set one missing for FavoriteFolder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We recently added a command to ensure uniqueness on the viewId column in the viewField table. This created some issues for some old workspaces that had viewFields with an empty viewId.
This command should get rid of those and set the column as non-nullable.
Also updating the onDelete action accordingly and set one missing for FavoriteFolder