Fix 1-click install tag version #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified the version fetching mechanism in the Docker install script to use GitHub's tags endpoint instead of the releases endpoint for determining installation version.
- Changed API endpoint from
/releases/latestto/tagsinpackages/twenty-docker/scripts/install.sh - Script now uses first tag from response which may include pre-releases or non-stable versions
- No error handling for API rate limiting or failed requests
- Lacks validation to ensure selected tag is a stable release version
- Missing graceful fallback if tag fetching fails
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -44,7 +44,7 @@ function on_exit { | |||
| trap on_exit EXIT | |||
|
|
|||
| # Use environment variables VERSION and BRANCH, with defaults if not set | |||
| version=${VERSION:-$(curl -s https://api.github.com/repos/twentyhq/twenty/releases/latest | grep '"tag_name":' | cut -d '"' -f 4)} | |||
| version=${VERSION:-$(curl -s https://api.github.com/repos/twentyhq/twenty/tags | grep '"name":' | head -n 1 | cut -d '"' -f 4)} | |||
There was a problem hiding this comment.
logic: No error handling for failed curl requests or GitHub API rate limiting. Could result in empty version string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #8689