Refactored and improved seeds #8695

lucasbordeau · 2024-11-22T22:43:05Z

Added a new Seeder service to help with custom object seeds
Added RichTextFieldInput to edit a rich text field directly on the table, but deactivated it for now.

greptile-apps

PR Summary

This PR adds comprehensive seeding functionality and rich text field support across the application, including new demo data and field types for testing.

Added RichTextFieldInput with BlockNote editor integration for inline rich text editing in tables
Introduced new SeederService with support for custom objects, composite fields, and improved data seeding capabilities
Added 10 new demo field types to Company seeds (UUID, RichText, Array, Rating, etc.) with corresponding metadata and views
Added new seed data files for pets and survey results with 100 records each for testing
Fixed color naming consistency from 'grey' to 'gray' across multiple theme and UI files

_{51 file(s) reviewed, 36 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

packages/twenty-front/src/modules/object-record/record-field/components/FieldInput.tsx

...ges/twenty-front/src/modules/object-record/record-field/meta-types/hooks/useRichTextField.ts

greptile-apps · 2024-11-22T22:46:22Z

...nty-front/src/modules/object-record/record-field/meta-types/hooks/useRichTextFieldDisplay.ts

+    fieldName,
+  );
+
+  const fieldValueParsed = parseJson<PartialBlock[]>(fieldValue);


logic: parseJson could return undefined/null - need to handle this case explicitly to avoid runtime errors when using fieldValueParsed

packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.ts

greptile-apps · 2024-11-22T23:17:35Z

packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts

+  @WorkspaceIsNullable()
+  demoRichText: string;


logic: demoRichText should be typed as FieldRichTextValue or string[] instead of string to match the RichText field type

packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts

packages/twenty-ui/src/display/tag/components/Tag.tsx

charlesBochet · 2024-11-28T13:31:41Z

.vscode/launch.json

@@ -44,8 +44,7 @@
        "nx",
        "run",
        "twenty-server:command",
-        "my-command",
-        "--my-parameter value",
+        "workspace:seed:demo",


+1 let's revert this

packages/twenty-front/src/modules/object-record/record-field/types/FieldMetadata.ts

charlesBochet · 2024-11-28T13:53:30Z

...c/engine/workspace-manager/demo-objects-prefill-data/seed-workspace-member-with-demo-data.ts

@@ -8,7 +8,7 @@ export const DEMO_SEED_WORKSPACE_MEMBER_IDS = {
  TIM: '20202020-1553-45c6-a028-5a9064cce07e',
 };

-export const workspaceMemberPrefillData = async (
+export const seedWorkspaceMemberWithDemoData = async (


we move it out from prefill data, aren't we breaking workspace creation?

I need to check

Any update on this breaking workspace creation?

...-server/src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids.ts

packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts

FelixMalfait · 2024-12-17T14:05:25Z

Small comment from @Bonapara: the default workspace of Tim Apple should be Apple and not ACME

Bonapara · 2024-12-17T14:22:58Z

Maybe we could use a fake logo to make it more fun:

Weiko · 2024-12-24T10:23:20Z

.vscode/launch.json

@@ -44,8 +44,7 @@
        "nx",
        "run",
        "twenty-server:command",
-        "my-command",
-        "--my-parameter value",
+        "workspace:seed:demo",


+1 let's revert this

packages/twenty-front/src/modules/object-record/record-field/components/FieldInput.tsx

...ages/twenty-server/src/modules/workflow/common/standard-objects/workflow.workspace-entity.ts

...erver/src/engine/metadata-modules/relation-metadata/hooks/before-delete-one-relation.hook.ts

packages/twenty-server/src/engine/seeder/data-seeds/pets-data-seeds.ts

Weiko · 2024-12-24T12:28:12Z

packages/twenty-server/src/engine/seeder/seeder.service.ts

+      throw new Error('No fields found for seeding, check metadata');
+    }
+
+    filteredFields.unshift({


I think "name" should already be there by the createOneObject?

Yes indeed, this bit of logic is not enough self-explanatory, it's here because the name field is inserted by default by the creation mechanism, so we have to add it to the array of fields here because we cannot control this mechanism, which could be problematic because it's like a silent behavior that is not obvious while working on this part of the code.

Weiko · 2024-12-24T12:31:11Z

packages/twenty-server/src/engine/seeder/seeder.service.ts

+    });
+
+    const fieldMetadataMap = filteredFields
+      .map((field) => {


nit: You should be able to use flatMap to avoid map().flat()

Suggested change

.map((field) => {

filteredFields

.flatMap((field) => {

if (!isCompositeFieldMetadataType(field.type)) {

return field.name;

}

const compositeFieldTypeDefinition = compositeTypeDefinitions.get(

field.type,

);

if (!isDefined(compositeFieldTypeDefinition)) {

throw new Error(

`Composite field type definition not found for ${field.type}`,

);

}

return (

compositeFieldTypeDefinition.properties?.map(

(property) => `${field.name}${capitalize(property.name)}`,

) ?? []

);

})

.filter(isDefined);

Weiko · 2024-12-24T12:32:59Z

packages/twenty-server/src/engine/seeder/seeder.service.ts

+      const flattenedSeed = {};
+
+      for (const field of filteredFields) {
+        if (isCompositeFieldMetadataType(field.type)) {


nit: Could be refactored, looks like we are doing the same checks here and above

Weiko · 2024-12-24T12:33:23Z

packages/twenty-server/src/engine/seeder/seeder.service.ts

+    private readonly workspaceDataSourceService: WorkspaceDataSourceService,
+  ) {}
+
+  public async seedCustomObjects(


nit: This method seems to have a lot of responsibilities, could be refactored in smaller functions maybe?

Weiko · 2024-12-24T12:34:12Z

...c/engine/workspace-manager/demo-objects-prefill-data/seed-workspace-member-with-demo-data.ts

@@ -8,7 +8,7 @@ export const DEMO_SEED_WORKSPACE_MEMBER_IDS = {
  TIM: '20202020-1553-45c6-a028-5a9064cce07e',
 };

-export const workspaceMemberPrefillData = async (
+export const seedWorkspaceMemberWithDemoData = async (


Any update on this breaking workspace creation?

Follow-up : Fixed relations eager load on refactored hooks from PR #8695

- Added a new Seeder service to help with custom object seeds - Added RichTextFieldInput to edit a rich text field directly on the table, but deactivated it for now.

Follow-up : Fixed relations eager load on refactored hooks from PR twentyhq#8695

lucasbordeau added 4 commits November 21, 2024 17:00

OK

5077f95

Ok

9bfd3aa

Fix

afa0c9c

Fix seeds

50c3df5

greptile-apps bot reviewed Nov 22, 2024

View reviewed changes

lucasbordeau added 9 commits November 25, 2024 11:38

Fix

047f44a

wip

dad62c4

Merge branch 'main' into feat/new-seeds

5c8b606

Refactor naming

6c3426c

Minor fixes

253da19

Fix readonly for new rich text field

4bfbb0b

Fixmin height

214d0d8

Fix

8ae3386

Fix

3fce159

lucasbordeau requested a review from charlesBochet November 26, 2024 18:00

charlesBochet reviewed Nov 28, 2024

View reviewed changes

packages/twenty-front/src/modules/object-record/record-field/types/FieldMetadata.ts Outdated Show resolved Hide resolved

charlesBochet reviewed Nov 28, 2024

View reviewed changes

...-server/src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids.ts Outdated Show resolved Hide resolved

charlesBochet reviewed Nov 28, 2024

View reviewed changes

packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts Outdated Show resolved Hide resolved

charlesBochet added the -PR: awaiting author label Nov 28, 2024

lucasbordeau added 2 commits November 28, 2024 15:17

Merge branch 'main' into feat/new-seeds

1247412

Fixed circular dependency problem

61ed304

lucasbordeau added -PR: wip and removed -PR: awaiting author labels Nov 29, 2024

charlesBochet added the -PR: awaiting author label Nov 29, 2024

charlesBochet assigned lucasbordeau Nov 29, 2024

Merge branch 'main' into feat/new-seeds

61ef4eb

lucasbordeau added 14 commits December 18, 2024 11:03

WIP

c4e121a

Fixes

a29acc0

Merge branch 'main' into feat/new-seeds

b1433d0

Removed unused field types

894a794

Removed fix from main

378e390

Put back changes from main

4fc18fb

Fixed rich text editor field input

7bfcb47

Merge branch 'main' into feat/new-seeds

59a48b2

Put back seed dev for now

1f53d0f

Use dropdown focus id for block editor click outside conflicts

7da7f1a

Fixed

5d9afc2

Fix lint

4a210bc

Merge branch 'main' into feat/new-seeds

59478a0

Merge branch 'main' into feat/new-seeds

6e36303

lucasbordeau enabled auto-merge (squash) December 24, 2024 11:42

Weiko reviewed Dec 24, 2024

View reviewed changes

Fix from comments

5bcb56f

Weiko approved these changes Dec 24, 2024

View reviewed changes

lucasbordeau merged commit e971760 into main Dec 24, 2024
22 checks passed

lucasbordeau deleted the feat/new-seeds branch December 24, 2024 13:44

lucasbordeau mentioned this pull request Dec 24, 2024

Fixed relations #9227

Merged

Weiko pushed a commit that referenced this pull request Dec 24, 2024

Fixed relations (#9227)

cba38ab

Follow-up : Fixed relations eager load on refactored hooks from PR #8695

samyakpiya pushed a commit to samyakpiya/twenty that referenced this pull request Dec 28, 2024

Fixed relations (twentyhq#9227)

e93f435

Follow-up : Fixed relations eager load on refactored hooks from PR twentyhq#8695

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored and improved seeds #8695

Refactored and improved seeds #8695

lucasbordeau commented Nov 22, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Nov 22, 2024

greptile-apps bot Nov 22, 2024

charlesBochet Nov 28, 2024

Weiko Dec 24, 2024 •

edited

Loading

charlesBochet Nov 28, 2024

lucasbordeau Dec 18, 2024

Weiko Dec 24, 2024 •

edited

Loading

lucasbordeau Dec 24, 2024

FelixMalfait commented Dec 17, 2024

Bonapara commented Dec 17, 2024

Weiko Dec 24, 2024 •

edited

Loading

Weiko Dec 24, 2024

lucasbordeau Dec 24, 2024

Weiko Dec 24, 2024

Weiko Dec 24, 2024

Weiko Dec 24, 2024

Weiko Dec 24, 2024 •

edited

Loading

-      .map((field) => {
+      filteredFields
+      .flatMap((field) => {
+        if (!isCompositeFieldMetadataType(field.type)) {
+          return field.name;
+        }
+        const compositeFieldTypeDefinition = compositeTypeDefinitions.get(
+          field.type,
+        );
+        if (!isDefined(compositeFieldTypeDefinition)) {
+          throw new Error(
+            `Composite field type definition not found for ${field.type}`,
+          );
+        }
+        return (
+          compositeFieldTypeDefinition.properties?.map(
+            (property) => `${field.name}${capitalize(property.name)}`,
+          ) ?? []
+        );
+      })
+      .filter(isDefined);

Refactored and improved seeds #8695

Refactored and improved seeds #8695

Conversation

lucasbordeau commented Nov 22, 2024 • edited Loading

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Nov 22, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Weiko Dec 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Weiko Dec 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FelixMalfait commented Dec 17, 2024

Bonapara commented Dec 17, 2024

Weiko Dec 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Weiko Dec 24, 2024 • edited Loading

Choose a reason for hiding this comment

lucasbordeau commented Nov 22, 2024 •

edited

Loading

Weiko Dec 24, 2024 •

edited

Loading

Weiko Dec 24, 2024 •

edited

Loading

Weiko Dec 24, 2024 •

edited

Loading

Weiko Dec 24, 2024 •

edited

Loading