fix-percentage #8684
Merged
fix-percentage #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added percentage symbol display functionality to number fields in the settings form when the field type is set to 'percentage', improving visual clarity for percentage value representation.
- Modified
packages/twenty-front/src/modules/settings/data-model/fields/forms/number/components/SettingsDataModelFieldNumberForm.tsxto include % symbol in preview display - Added conditional rendering logic to append % for percentage type fields
- Note: TODO comment regarding maxValue needs attention in future updates
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -69,7 +69,7 @@ export const SettingsDataModelFieldNumberForm = ({ | |||
| <SettingsOptionCardContentCounter | |||
| Icon={IconDecimal} | |||
| title="Number of decimals" | |||
| description={`Example: ${(1000).toFixed(count)}`} | |||
| description={`Example: ${(1000).toFixed(count)} ${type === 'percentage' ? '%' : ''}`} | |||
There was a problem hiding this comment.
style: Consider formatting the example number (1000) differently for percentage display - 1000% might be confusing to users
martmull
reviewed
Nov 22, 2024
| @@ -69,7 +69,7 @@ export const SettingsDataModelFieldNumberForm = ({ | |||
| <SettingsOptionCardContentCounter | |||
| Icon={IconDecimal} | |||
| title="Number of decimals" | |||
| description={`Example: ${(1000).toFixed(count)}`} | |||
| description={`Example: ${(1000).toFixed(count)} ${type === 'percentage' ? '%' : ''}`} | |||
There was a problem hiding this comment.
Suggested change
| description={`Example: ${(1000).toFixed(count)} ${type === 'percentage' ? '%' : ''}`} | |
| description={`Example: ${(type === 'percentage' ? 99 : 1000).toFixed(count)} ${type === 'percentage' ? '%' : ''}`} |
martmull
approved these changes
Nov 22, 2024
|
Thanks @guillim for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following previous release, a suggestion was noticed by @martmull . Here is a suggested fix.
Before :
After :
