Fix interactive install script #8669
Merged
+7
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the installation process to improve security by downloading and verifying the install script before execution, rather than piping directly to bash.
- Modified
/packages/twenty-docker/scripts/1-click.shto download script totwenty_install.shinstead of direct pipe to bash - Added version comparison logic to handle script location change in v0.32.4
- Added
chmod +xcommand to ensure script is executable before running - Added cleanup step to remove downloaded script after execution
- Maintained backward compatibility by supporting both old and new script locations
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
9
to
11
| curl -L "https://raw.githubusercontent.com/twentyhq/twenty/$pull_branch/packages/twenty-docker/scripts/install.sh" -o twenty_install.sh | ||
| else | ||
| curl -sL "https://raw.githubusercontent.com/twentyhq/twenty/$pull_branch/install.sh" | bash -- "$VERSION" "$BRANCH" | ||
| curl -sL "https://raw.githubusercontent.com/twentyhq/twenty/$pull_branch/install.sh" -o twenty_install.sh |
There was a problem hiding this comment.
logic: Missing error handling for failed curl downloads. Script continues even if download fails.
Comment on lines
14
to
15
| chmod +x twenty_install.sh | ||
| ./twenty_install.sh "$VERSION" "$BRANCH" |
There was a problem hiding this comment.
logic: Missing check if twenty_install.sh exists before chmod and execution
| chmod +x twenty_install.sh | ||
| ./twenty_install.sh "$VERSION" "$BRANCH" | ||
|
|
||
| rm twenty_install.sh |
There was a problem hiding this comment.
style: rm should use -f flag to prevent errors if file doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to fix the interactive install script, by downloading the file first and then executing it