Temporarily restore install.sh #8639
Merged
+168
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR temporarily restores the install.sh script, providing an automated installation process for the Twenty CRM project using Docker.
- Implements comprehensive dependency checks for Docker, Docker Compose, and curl with clear error messages
- Handles version compatibility checks for Docker Compose (>= v2) with appropriate warnings
- Generates secure random secrets for APP_SECRET, PGPASSWORD_SUPERUSER, and POSTGRES_ADMIN_PASSWORD
- Features interactive port configuration with automatic detection of port conflicts
- Includes OS-specific handling for both Linux and macOS environments with appropriate sed commands
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+108
to
+110
| if [ "$answer" = "n" ]; then | ||
| continue | ||
| fi |
There was a problem hiding this comment.
logic: Answering 'n' to use another port causes an infinite loop since continue is used in a while loop checking port availability
Comment on lines
+136
to
+138
| while [ ! $(docker inspect --format='{{.State.Health.Status}}' twenty-server-1) = "healthy" ]; do | ||
| sleep 1 | ||
| done |
There was a problem hiding this comment.
logic: No timeout on health check wait loop could cause script to hang indefinitely if container never becomes healthy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git.new link can't be change. Let's remove this file tomorrow