Refactor standard relations update at custom object renaming #8638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored standard relations update logic during custom object renaming to improve reliability and clarity of metadata handling.
- Extracted foreign key metadata generation into new utility
buildNameLabelAndDescriptionForForeignKeyFieldMetadata.util.tsfor consistent naming patterns - Added
settings: { isForeignKey: true }property inrelation-metadata.service.tsto properly identify foreign key fields - Improved precision of relation updates in
object-metadata-migration.service.tsby adding workspaceId and objectMetadataId checks - Renamed
createRelationsUpdatesMigrationstocreateStandardRelationsUpdatesMigrationsfor better clarity of purpose - Added proper field metadata updates for name, label and description during object renaming operations
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
166
to
177
| await this.fieldMetadataRepository.update( | ||
| { | ||
| name: existingObjectMetadata.nameSingular, | ||
| label: existingObjectMetadata.labelSingular, | ||
| objectMetadataId: relatedObject.id, | ||
| workspaceId: workspaceId, | ||
| }, | ||
| { | ||
| name: updatedObjectMetadata.nameSingular, | ||
| label: updatedObjectMetadata.labelSingular, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
logic: This update could affect multiple records unintentionally since it's not scoped to a specific field type or relation
| }) => { | ||
| const name = `${targetObjectNameSingular}Id`; | ||
| const label = `${targetObjectLabelSingular} ID (foreign key)`; | ||
| const description = `${relatedObjectLabelSingular} ${targetObjectLabelSingular} id foreign key`; |
There was a problem hiding this comment.
style: description format is inconsistent with label format - 'id' should be capitalized as 'ID' to match label style
Weiko
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring update of standard relations when a custom object is renamed, after observing occasional issues.