Create form field number #8634
Draft
Create form field number #8634
+606
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
reviewed
Nov 21, 2024
| `; | ||
|
|
||
| const StyledInputContainer2 = styled.div<{ | ||
| multiline?: boolean; |
There was a problem hiding this comment.
multiline not needed for number
| flex-direction: column; | ||
| `; | ||
|
|
||
| const StyledInputContainer = styled.div<{ |
There was a problem hiding this comment.
Should be a common Overlay for primitive components
| <StyledVariableContainer> | ||
| {extractVariableLabel(draftValue)} | ||
|
|
||
| <button |
There was a problem hiding this comment.
don't we have a component already for this?
| <StyledInputContainer> | ||
| <StyledInputContainer2> | ||
| {editingMode === 'input' ? ( | ||
| <StyledInput |
There was a problem hiding this comment.
let's separate:
- FormNumberFieldInput should be a simple number input with a FormOverlay to add design
- Variable button / dropdown should come from the parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
FormFieldInput.To do:
isTextField(),isNumberField(), etc. calls in a separateFormFieldcomponent that we can reuse across actions